fix: Use APP_DOMAIN env var for bot user email#9262
Conversation
…lane.so Signed-off-by: okxint <cashmein.eth@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe bot user email address generated during workspace seeding in ChangesBot User Email Domain Configuration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Shouldn't this go through the proper configuration system that plane has? reading it directly from the environment there is very side effectful and possibly unexpected. As far as I am aware |
Bot user email was hardcoded as
bot_user_{id}@plane.soduring workspace seeding. Self-hosted instances with a customAPP_DOMAINwould end up with bot accounts on the wrong domain.Replaced the hardcoded domain with
os.environ.get('APP_DOMAIN', 'plane.so')— defaults toplane.soso Plane Cloud is unaffected.Closes #9251
Summary by CodeRabbit