fix: escape slashes in environment variable values during update #8081
+1
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change fixes an issue with syncing environment file values that contain slashes.
Previously, sed would throw the following errors when attempting to update these values:
Type of Change
Screenshots and Media (if applicable)
Test Scenarios
Apply changes to
setup.shand use it to upgrade the application. Environment variables containing slashes, such asDATABASE_URLandAWS_S3_ENDPOINT_URL, should sync correctly.References
Closes #8011
Note
Escapes
/in environment variable values when updatingplane.envon non-macOS to prevent sed substitution errors.deployments/cli/community/install.sh):updateEnvFilefor non-macOS: pre-escape/invaluebeforesed -isubstitution to avoid delimiter errors when syncing env vars.Written by Cursor Bugbot for commit 561229c. This will update automatically on new commits. Configure here.
Summary by CodeRabbit