allow to use 'authenticate' without logging in#2
Merged
midahp merged 3 commits intomaintaina-com:FRAMEWORK_6_0from Feb 3, 2025
Merged
allow to use 'authenticate' without logging in#2midahp merged 3 commits intomaintaina-com:FRAMEWORK_6_0from
midahp merged 3 commits intomaintaina-com:FRAMEWORK_6_0from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
authenticate has a
$loginparameter that should cause the method to just check credentials if it is set tofalse.This parameter was not used before.
Related PR: maintaina-com/Core#37
Both PRs by themself should prevent the method from logging in when
loginis set tofalse, but ideally they should be used together.