Repository navigation
fix: add accessible names to v8 docsite navigation and CommandBar examples - #40
Draft
mainframev wants to merge 29 commits into
Draft
mainframev wants to merge 29 commits into
mainframev wants to merge 29 commits into
Conversation
…0.8 (microsoft#36883) Co-authored-by: Carlos Perez (M365) <caperez+microsoft@microsoft.com> Co-authored-by: Paul Mardling <paulmardling@microsoft.com>
…crosoft#36969) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…soft#36752) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Martin Hochel <martinhochel@microsoft.com> Copilot-Session: ed39bb7d-827b-40e9-bc3b-3bf27e334d85 Copilot-Session: 176a875a-00fc-4f92-8657-efeb3a6e62a1 Copilot-Session: 92cc9ccd-6e8f-4638-8c08-b2323aa950a1 Copilot-Session: f94cca35-e6fc-4bee-8616-d5120bec27c4
…o 3.0.5 (microsoft#36924) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…b-actions-minor-patch group across 1 directory (microsoft#36922) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…dependencies group across 1 directory (microsoft#36998) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Hotell <1223799+Hotell@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…soft#37017) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Martin Hochel <martinhochel@microsoft.com> Copilot-Session: b2dea0c5-9693-406d-8e08-38a6334389fb
…d nested theme values (microsoft#36985)
Co-authored-by: Dmytro Kirpa <dmytrokirpa@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…osoft#36987) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…t#36886) Co-authored-by: Paul Mardling <paulmardling@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…mples The v8 docsite left page nav and five Nav/CommandBar examples rendered navigation and menubar regions without an accessible name, so screen reader users could not tell them apart (ADO 36762).
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
On the v8 docsite (developer.microsoft.com/fluentui), several
navigationandmenubarregions had no accessible name, so screen reader users heard several identical "navigation" or "menu bar" landmarks and could not tell them apart:<nav role="navigation">inpublic-docsite)ButtonAs,CommandBarButtonAs,SplitDisabled,Lazy)New Behavior
ariaLabel, following the "Nav example with …" naming the other examples already use.No component changes:
Nav,CommandBarandOverflowSetalready support an accessible name. Both changed packages are private, so there is no change file.Screenshots
Unnamed regions are outlined with a dashed red line, named ones with a solid green line. Before is the live docsite, after is the local docsite.
The local docsite also shows an unnamed top nav (
TopNavin@fluentui/react-docsite-components). Production replaces it with the Microsoft site header, which is already labeled, so it is out of scope here.Related Issue(s)