Skip to content

Release version 2.9.0#99

Merged
i7an merged 4 commits intomainfrom
release/2.9.0
Mar 13, 2026
Merged

Release version 2.9.0#99
i7an merged 4 commits intomainfrom
release/2.9.0

Conversation

@i7an
Copy link
Contributor

@i7an i7an commented Mar 12, 2026

Motivation

Release version 2.9.0

Changes

  • Add Sending Stats API
  • Parse reply_to as a structured address field instead of passing it as a raw
    header when sending with Action Mailer

How to test

  • Stats
  • Reply-To field

Summary by CodeRabbit

  • New Features
    • reply_to field is now parsed as a structured address field when sending with Action Mailer, improving consistency with standard email field handling.

@i7an i7an requested a review from piobeny March 12, 2026 11:58
@i7an i7an mentioned this pull request Mar 12, 2026
@coderabbitai
Copy link

coderabbitai bot commented Mar 12, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 46bbd003-f1b5-490c-8af8-d09ac6ef42b2

📥 Commits

Reviewing files that changed from the base of the PR and between 364c5b6 and aead0fa.

⛔ Files ignored due to path filters (1)
  • Gemfile.lock is excluded by !**/*.lock
📒 Files selected for processing (4)
  • CHANGELOG.md
  • lib/mailtrap/mail.rb
  • lib/mailtrap/version.rb
  • spec/mailtrap/mail_spec.rb

📝 Walkthrough

Walkthrough

Version 2.9.0 release bumping library to latest version with changelog entry documenting the change from raw header to structured address field parsing for reply_to in Action Mailer integration. Includes code formatting adjustments and test refactoring.

Changes

Cohort / File(s) Summary
Release Versioning
CHANGELOG.md, lib/mailtrap/version.rb
Bumped version to 2.9.0 and added changelog entry documenting structured reply_to address field parsing for Action Mailer.
Code Formatting
lib/mailtrap/mail.rb
Moved RuboCop disable directive from separate lines to inline annotation on from_message method definition.
Test Updates
spec/mailtrap/mail_spec.rb
Simplified reply-to header tests, expanded invalid header test coverage to include 'reply-to', and updated error message expectations using Mail::Field::FIELD_NAME_MAP.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • #97: Both PRs modify Mailtrap::Mail.from_message and handle Reply-To field mapping from raw headers to structured address fields.
  • #70: Both PRs modify mail header handling in lib/mailtrap/mail.rb for address/header parsing with Action Mailer.
  • #65: Both PRs modify release artifacts including CHANGELOG.md and lib/mailtrap/version.rb version constant updates.

Suggested reviewers

  • mklocek
  • IgorDobryn

Poem

🐰 A version hops up to point-nine-oh,
Reply-to fields now steal the show!
From raw headers wild to structures neat,
Tests trimmed back make the release complete! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Release version 2.9.0' directly matches the primary objective of the pull request, which is releasing version 2.9.0.
Description check ✅ Passed The description includes all required template sections (Motivation, Changes, How to test) with appropriate content matching the PR objectives.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch release/2.9.0

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@i7an i7an requested a review from mklocek March 12, 2026 11:58

it { is_expected.to eq(expected_headers) }
end

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the tests that test Mail gem rather then Mailtrap and tests that duplicate other tests.

@i7an i7an merged commit 457328b into main Mar 13, 2026
4 checks passed
@i7an i7an deleted the release/2.9.0 branch March 13, 2026 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants