MT-22147: Document search param on GET /api/contacts/lists#45
Conversation
Add the optional `search` query param (case-insensitive partial name match) to the Get all Contact Lists operation, mirroring the search parameter convention used elsewhere, plus a ?search= cURL example. Note: this path still documents a 500 response, which violates the api-creator "no 500" rule. Left as-is to keep this PR focused; flagged as a follow-up cleanup.
📝 WalkthroughWalkthroughThe ChangesSearch parameter for contact lists endpoint
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@specs/contacts.openapi.yml`:
- Around line 1245-1246: The cURL examples in the contacts.openapi.yml file
contain hardcoded token placeholders (YOUR_API_TOKEN) in the Authorization
header, which should be replaced with environment variable references according
to repo guidelines. Update both instances of the curl commands (around lines
1245-1246 and 1249-1250) where the -H 'Authorization: Bearer YOUR_API_TOKEN'
header appears to use an environment variable syntax instead of the hardcoded
placeholder string.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 9ffa9385-27ac-4329-badb-99f6e368e43e
📒 Files selected for processing (1)
specs/contacts.openapi.yml
Motivation
https://railsware.atlassian.net/browse/MT-22147
Changes
searchquery param (case-insensitive partial name match) onGET /api/contacts/lists, with a matching cURL exampleHow to test
GET /api/contacts/listsshows an optionalsearchquery param described as "Filter contact lists by name (case-insensitive partial match)."Summary by CodeRabbit
searchquery parameter to filter contact lists by name using a case-insensitive prefix match.?search=....