Skip to content

Always print html-analysis output as JSON - #11

Open
mklocek wants to merge 1 commit into
mainfrom
fix-html-analysis-empty-output
Open

Always print html-analysis output as JSON#11
mklocek wants to merge 1 commit into
mainfrom
fix-html-analysis-empty-output

Conversation

@mklocek

@mklocek mklocek commented Aug 3, 2026

Copy link
Copy Markdown

Problem

mailtrap messages html-analysis --sandbox-id <id> --id <id> returned nothing in the response.

The command returns an unstructured JSON payload but printed it using the configured output format. With the default table format and no column definitions, the formatter emitted nothing, so the command appeared to return an empty response.

Fix

Hardcode JSON output, matching the sibling spam-score command which returns the same kind of payload.

Tests

Updated the html-analysis test to run under the default table format so it guards against this regression, instead of forcing json output which was masking the bug. Verified it fails (empty output) without the fix and passes with it. Full go build / go vet / go test ./... all green.

The html-analysis command returns an unstructured JSON payload but
printed it using the configured output format. With the default table
format and no column definitions, the formatter emitted nothing, so the
command appeared to return an empty response.

Hardcode JSON output, matching the sibling spam-score command which
returns the same kind of payload.

Update the html-analysis test to run under the default table format so
it guards against this regression, instead of forcing json output which
masked the bug.
@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@mklocek, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 48 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f77412a0-0928-49d1-99dc-c8b1010f3284

📥 Commits

Reviewing files that changed from the base of the PR and between 1c2f517 and e69623d.

📒 Files selected for processing (2)
  • internal/commands/messages/html_analysis.go
  • internal/commands/messages/messages_extended_test.go

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant