Always print html-analysis output as JSON - #11
Conversation
The html-analysis command returns an unstructured JSON payload but printed it using the configured output format. With the default table format and no column definitions, the formatter emitted nothing, so the command appeared to return an empty response. Hardcode JSON output, matching the sibling spam-score command which returns the same kind of payload. Update the html-analysis test to run under the default table format so it guards against this regression, instead of forcing json output which masked the bug.
|
Warning Review limit reached
Next review available in: 48 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Problem
mailtrap messages html-analysis --sandbox-id <id> --id <id>returned nothing in the response.The command returns an unstructured JSON payload but printed it using the configured output format. With the default
tableformat and no column definitions, the formatter emitted nothing, so the command appeared to return an empty response.Fix
Hardcode JSON output, matching the sibling
spam-scorecommand which returns the same kind of payload.Tests
Updated the
html-analysistest to run under the defaulttableformat so it guards against this regression, instead of forcingjsonoutput which was masking the bug. Verified it fails (empty output) without the fix and passes with it. Fullgo build/go vet/go test ./...all green.