Open
Conversation
robdefeo
requested changes
Apr 24, 2024
Member
robdefeo
left a comment
robdefeo
left a comment
There was a problem hiding this comment.
I like this, this is a really good solution. Couple of small changes and let's get the other pull request merged.
verifier-integration/js/index.js
Outdated
Comment on lines
10
to
12
| const VIDOS_RESOLVER_URL = undefined; // 'https://ugly-aqua-hummingbird-120.resolver.service.eu.vidos.local'; | ||
| const VIDOS_API_KEY = undefined; // '24b500499e7c2f0a8634831d1b9894b74d656d3e7cd6de238d706c20a5db6d41'; | ||
|
|
Member
There was a problem hiding this comment.
Looks like some debug lines here
verifier-integration/js/index.js
Outdated
| ethURL, | ||
| contractAddress | ||
| ); | ||
| const vidosResolver = VIDOS_RESOLVER_URL && VIDOS_API_KEY ? new VidosResolver(VIDOS_RESOLVER_URL, VIDOS_API_KEY) : undefined; |
Member
There was a problem hiding this comment.
Need a way to get the config inserted into these environment variables
| }, | ||
| }); | ||
| const result = await response.json(); | ||
| // console.log("root result", JSON.stringify(result, null, 2)); |
Member
There was a problem hiding this comment.
Presumably a debugging statement
robdefeo
reviewed
Apr 25, 2024
robdefeo
reviewed
Apr 25, 2024
antonio-ivanovski
changed the title
robdefeo
reviewed
May 13, 2024
robdefeo
approved these changes
May 13, 2024
Member
robdefeo
left a comment
robdefeo
left a comment
There was a problem hiding this comment.
Looks good, made a small change to remove specific endpoint
robdefeo
approved these changes
May 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VidosResolver Implementation: mailchain/js-iden3-auth#1
To get this example working while there is no js-iden3-auth lib published that includes
VidosResolverjs-iden3-authdonpm install,npm run buildandnpm linkvidos-resolver-examplepolygonid-tutorial-examples, cd intoverifier-integration/jspackage,npm installandnpm link @iden3/js-iden3-auth.envfileNODE_TLS_REJECT_UNAUTHORIZED="0" node .otherwise justnode .