new Tempo.versions property#56
Merged
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughThis PR bumps package versions to 3.7.0, adds a Tempo runtime version registry and versioned plugin/term metadata, migrates Tempo internals to class-private fields, updates term lookup wiring, and reworks version-sync.mjs to handle workspaces individually. ChangesVersion Sync Script
Tempo Version Registry and Private Field Refactor
Estimated code review effort: 4 (Complex) | ~50 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
bin/version-sync.mjs (1)
18-20: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winInner
catchdiscards the error object.The caught
erroris declared but never used. Whilestdio: 'inherit'surfaces npm's own stderr, the JS error object (exit status, captured output) is lost. Including it in the warning preserves diagnostics if stdio is ever changed and aids debugging unexpected failures.♻️ Include error details in the warning
} catch (error) { - console.warn(`⚠️ Bypassed ${ws} (likely already at ${version} or not found).`); + console.warn(`⚠️ Bypassed ${ws} (likely already at ${version} or not found).`, error instanceof Error ? error.message : error); }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@bin/version-sync.mjs` around lines 18 - 20, The inner catch in version-sync.mjs ignores the caught error, so the warning loses useful diagnostics. Update the catch block in the version-sync flow to include the error object in the console.warn output, using the caught error from the npm install/fixup step so exit status and any captured details are preserved. Keep the existing warning context around ws and version, but make the message explicitly surface the error from that catch.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@bin/version-sync.mjs`:
- Around line 14-22: The workspace sync loop in version-sync.mjs always reports
success even if every execSync call fails; update the script to track whether
any workspace was actually synced versus bypassed inside the existing workspaces
loop. Use the current try/catch around execSync and the final completion log to
either emit a failure message or exit non-zero when all workspaces are bypassed,
so version-bump.mjs can detect a total sync failure correctly.
In `@packages/tempo/src/tempo.class.ts`:
- Around line 104-109: Update the Tempo public version source so Tempo.version
and Tempo.versions.Tempo return the new release value. The stale value comes
from the TEMPO_VERSION constant referenced by Tempo.#versions in tempo.class.ts,
so bump the exported version in tempo.version.ts to 3.7.0 and ensure the
build-time stamp used by Tempo.version is updated consistently.
---
Nitpick comments:
In `@bin/version-sync.mjs`:
- Around line 18-20: The inner catch in version-sync.mjs ignores the caught
error, so the warning loses useful diagnostics. Update the catch block in the
version-sync flow to include the error object in the console.warn output, using
the caught error from the npm install/fixup step so exit status and any captured
details are preserved. Keep the existing warning context around ws and version,
but make the message explicitly surface the error from that catch.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: a1019f52-85af-4a31-8346-cb0fe55e2aa1
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (12)
bin/version-sync.mjspackage.jsonpackages/library/package.jsonpackages/tempo/CHANGELOG.mdpackages/tempo/doc/releases/v3.x.mdpackages/tempo/package.jsonpackages/tempo/src/module/module.format.tspackages/tempo/src/plugin/plugin.type.tspackages/tempo/src/plugin/plugin.util.tspackages/tempo/src/plugin/term/term.type.tspackages/tempo/src/plugin/term/term.util.tspackages/tempo/src/tempo.class.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Tempo.versionsto report loaded core modules and plugins.version, and terms get a default version when omitted.