Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatic HTTP and WebSocket redirects forwarded caller-supplied
AuthorizationandCookieheaders to different origins. A redirect between two local server ports reproduces the credential leak on master in both clients.Remove those headers when a redirect changes scheme, hostname or effective port. A shared
UrlParser::isSameOrigin()comparison handles scheme/hostname case and default ports. Credentials remain removed throughout that redirect chain, including a subsequent return to the original origin. Same-origin redirects retain them, and the caller's configuration stays unchanged for future requests or connections. Other custom headers retain their existing behavior, which is documented.This follows the redirect credential guidance in RFC 9110 §15.4.
Validation:
git clang-formatandgit diff --checkpass.