Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling
SocketAppleSSL::close()before a TLS context existed returned without closing an adopted native descriptor. This could keep the descriptor open until the socket object was destroyed. Always close the native socket after optionally releasing the TLS context, matching the OpenSSL and MbedTLS backends.The regression test uses an unconnected local descriptor and checks immediate closure with and without a TLS context. It failed on master and passes with the fix; both cases take less than a millisecond and use no sleeps or timeout waits.
Validation: complete SecureTransport suite, 31/31 passed; TLS adapter tests, 28 assertions passed. Production builds as C++11 with warnings treated as errors (legacy SecureTransport deprecation warnings excluded).
git clang-formatandgit diff --checkpass.