Repository navigation
Conversation
This was referenced Nov 17, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarify the existing APIs that answer #472, #522 and #425: retaining weak connection handles for later sends, starting multiple clients concurrently, and explicitly enabling TLS on a server listener.
Fix the connection-setup example's callback delimiters, missing reference in the message callback, and access to a private ConnectionState field. Replace the TLS designated-initializer example with C++11-compatible server/client configuration. Describe safe weak-handle lookup by connection ID and avoid implying the setup callback is deprecated.
Validation: the corrected connection-setup and TLS examples compile with
-std=c++11 -pedantic-errors. The corrected shutdown/concurrent-client reproduction completed ten rounds and twenty connections under ThreadSanitizer in 81 ms. Existing proxy and TLS tests also pass on current master.