Repository navigation
Reject truncated gzip streams instead of returning partial success - #652
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A truncated gzip body can currently return success with partial or empty output because decoding stops as soon as the output buffer is not full. This also accepts input missing the gzip checksum/trailer.
Require Z_STREAM_END before returning success and reject zlib error/no-progress results. Preserve the existing append-to-output behavior for valid streams.
Validation: exhaustively truncate the compressed representations of empty, small and 32 KiB payloads at every byte boundary; also check complete streams, binary content and a corrupt checksum. Master fails 109 assertions; the fix passes all 121. These tests are in memory, with no sleeps or network requests, and finish in milliseconds. Combined plain-socket suite: 30/30 passed; targeted ASan/UBSan checks passed. Strict C++11 production build, formatting and diff checks passed.