Repository navigation
Preserve socket errors in connection failure diagnostics - #645
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Failed nonblocking connects can report stale or zero errors. Query
SO_ERRORfor write readiness on Windows and POSIX, preserve a failinggetsockopt()error, and save the error before closing the descriptor. Format native errors throughstd::system_category()so Winsock errors receive the correct description. Also compare socket handles against their correctly typed invalid value.Refs #543. This addresses misleading diagnostics; the original application's connection failure still needs its own current reproducer.
Validation: immediate invalid-handle regression test; connection/reconnect tests pass; full plain-socket suite 28/28 passed. C++11 warnings-as-errors build and MinGW compilation checks passed (an unrelated pre-existing unused-parameter warning is suppressed in the direct cross-compile check). The refused-loopback test was removed because Windows TCP retries make it slow. Changed C++ formatted;
git diff --checkpassed.