Fix lint CI workflow#25
Merged
Merged
Conversation
grahamgilbert
force-pushed
the
fix-lint-ci
branch
2 times, most recently
from
d7c177a to
0addbc9
Compare
grahamgilbert
force-pushed
the
fix-lint-ci
branch
from
0addbc9 to
786a5c4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the failing lint job seen on PR #24. The old workflow ran setup-go before checkout and did not pin the Go version, so Actions resolved Go 1.26 while golangci-lint v1.64.8 was built with Go 1.24, causing typecheck failures before lint could run cleanly. This updates the lint workflow to checkout first, use setup-go v6 with go.mod, and pins golangci-lint-action to the v6 line with golangci-lint v1.64.8 so the existing lint behavior is preserved. Verified locally with: GOCACHE=/tmp/default-browser-go-build GOMODCACHE=/tmp/default-browser-go-mod go test ./...; GOCACHE=/tmp/default-browser-go-build GOMODCACHE=/tmp/default-browser-go-mod go run github.com/golangci/golangci-lint/cmd/golangci-lint@v1.64.8 run.