refactor: address ecommerce review types without changing runtime - #1367
Draft
jaissica12 wants to merge 3 commits into
Draft
refactor: address ecommerce review types without changing runtime#1367jaissica12 wants to merge 3 commits into
jaissica12 wants to merge 3 commits into
Conversation
jaissica12
force-pushed
the
refactor/SDKE-1108-ecommerce-type-followup
branch
from
August 25, 2026 01:56
1d71c77 to
6516202
Compare
* refactor: migrate ecommerce module to TS Rename ecommerce.js to ecommerce.ts and add types. Keep function() style and self = this. Align IECommerce with the SDKEvent/SDKProduct shapes the runtime already uses. * refactor: tighten ecommerce TS types and convert eCommerce tests Align impression/promotion signatures with runtime arrays, drop unused event-models types, and migrate tests-eCommerce to TypeScript. * refactor: drop non-required ecommerce.ts type cleanup Keep createImpression on SDKProduct; restore the remaining casts and formatting from the migration commit so this PR stays compile-required only. * refactor: type logPromotionEvent to accept a promotion or array * refactor: destructure Messages from Constants in ecommerce
Base automatically changed from
refactor/SDKE-1108-update-ecommerce-module-to-TS
to
development
August 25, 2026 14:21
jaissica12
force-pushed
the
refactor/SDKE-1108-ecommerce-type-followup
branch
from
August 25, 2026 14:21
18df836 to
1c529ec
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
What Has Changed
Screenshots/Video
Checklist
Additional Notes
Reference Issue (For employees only. Ignore if you are an outside contributor)