feat: update release process#1210
Open
nickolas-dimitrakas wants to merge 20 commits intoworkstation/3.0-Releasefrom
Open
feat: update release process#1210nickolas-dimitrakas wants to merge 20 commits intoworkstation/3.0-Releasefrom
nickolas-dimitrakas wants to merge 20 commits intoworkstation/3.0-Releasefrom
Conversation
jamesnrokt
reviewed
Mar 12, 2026
Sub-package build scripts delegated to kits/adobe/ root but skipped build:heartbeat, causing rollup to fail resolving HeartbeatKit/dist when each package is built independently via the kit CI matrix. #agentic
…ke from pull-request.yml android-bridge-tests, cross-browser-testing, and cross-browser-testing-beta previously triggered independently on pull_request. Converts them to workflow_call (keeping workflow_dispatch where applicable) and calls them from pull-request.yml, matching the pattern from mparticle-apple-sdk#554. This surfaces all checks under a single workflow in the Actions tab and enables the visual flow diagram. #agentic
nickolas-dimitrakas
requested review from
a team,
alexs-mparticle,
jaissica12,
jamesnrokt and
rmi22186
| { | ||
| "name": "@mparticle/web-adobe-kit", | ||
| "version": "2.0.1", | ||
| "private": true, |
Collaborator
There was a problem hiding this comment.
Why are we marking this as private?
Contributor
Author
There was a problem hiding this comment.
@alexs-mparticle I added as a safeguard that ensures this root is just a build orchestrator, not a publishable artifact for npm.
There was a problem hiding this comment.
Pull request overview
Consolidates standalone “kit” integrations into the core Web SDK monorepo (kits/) and updates the release/CI pipelines to build, test, and publish kit bundles alongside the core SDK.
Changes:
- Extends
scripts/release.shto build kit bundles, stagedist/outputs, and synchronize kitpackage.jsonversions to the SDK release version. - Updates semantic-release configuration to accommodate multi-package release commits and release rule coverage.
- Updates GitHub workflows to add PR checks and to orchestrate staging release steps (including kit tests/publishing and post-release lockfile refresh).
Reviewed changes
Copilot reviewed 40 out of 42 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/release.sh | Adds argument validation, kit build/staging/version-bump steps, and related commits |
| release.config.js | Adjusts release rules and expands git-commit assets to include all package manifests/locks |
| kits/twitter/package.json | Adds ESM/IIFE artifacts to publish files and module entry |
| kits/taplytics/package.json | Adds ESM/IIFE artifacts to publish files and module entry |
| kits/simplereach/package.json | Adds ESM/IIFE artifacts to publish files and module entry |
| kits/rokt/package.json | Adds ESM artifact to publish files and module entry |
| kits/optimizely/package.json | Adds ESM/IIFE artifacts to publish files and module entry |
| kits/onetrust/package.json | Adds ESM/IIFE artifacts to publish files and module entry |
| kits/mixpanel/mixpanel-2/package.json | Adds ESM/IIFE artifacts to publish files and module entry |
| kits/matrix.json | Splits GA4 and Adobe entries into client/server package paths |
| kits/localytics/localytics-4/package.json | Adds ESM/IIFE artifacts to publish files and module entry |
| kits/leanplum/leanplum-1/package.json | Adds ESM/IIFE artifacts to publish files and module entry |
| kits/kissmetrics/package.json | Adds ESM/IIFE artifacts to publish files and module entry |
| kits/intercom/package.json | Adds ESM/IIFE artifacts to publish files and module entry |
| kits/inspectlet/package.json | Adds ESM/IIFE artifacts to publish files and module entry |
| kits/id5/id5-1/package.json | Adds ESM/IIFE artifacts to publish files and module entry |
| kits/heap/package.json | Adds ESM/IIFE artifacts to publish files and module entry |
| kits/google-tag-manager/package.json | Adds ESM/IIFE artifacts to publish files and module entry |
| kits/google-analytics-4/packages/GA4Server/package.json | Adds ESM artifact to publish files and module entry |
| kits/google-analytics-4/packages/GA4Client/package.json | Fixes file path and adds ESM artifact plus module entry |
| kits/facebook/package.json | Adds IIFE artifact to publish files |
| kits/dynamic-yield/package.json | Adds ESM/IIFE artifacts to publish files and module entry |
| kits/doubleclick/package.json | Adds ESM/IIFE artifacts to publish files and module entry |
| kits/device-match/package.json | Adds ESM/IIFE artifacts to publish files and module entry |
| kits/criteo/package.json | Adds ESM/IIFE artifacts to publish files and module entry |
| kits/braze/braze-5/package.json | Adds IIFE artifact to publish files |
| kits/braze/braze-4/package.json | Adds ESM/IIFE artifacts and module entry |
| kits/braze/braze-3/package.json | Adds ESM/IIFE artifacts and module entry |
| kits/bingads/package.json | Adds ESM/IIFE artifacts, module entry, and removes stray whitespace |
| kits/adwords/package.json | Fixes dist filename typo and adds ESM/IIFE artifacts plus module entry |
| kits/adobe/packages/AdobeServer/package.json | Adds browser/files/module fields and build/test scripts for monorepo context |
| kits/adobe/packages/AdobeServer/package-lock.json | Adds lockfile for AdobeServer package |
| kits/adobe/packages/AdobeClient/package.json | Adds browser/files/module fields and build/test scripts for monorepo context |
| kits/adobe/packages/AdobeClient/package-lock.json | Updates lockfile format/version for AdobeClient package |
| kits/adobe/package.json | Marks Adobe umbrella package as private |
| kits/adobe-target/package.json | Adds ESM/IIFE artifacts to publish files and module entry (and fixes prior file list typo) |
| .github/workflows/staging-step-1.yml | Adds SDK packing for kit tests, kit tests against local tarball, kit publishing, and post-release lock refresh |
| .github/workflows/release.yml | Removes legacy release workflow |
| .github/workflows/pull-request.yml | Adds reusable workflow calls for Android bridge and BrowserStack tests |
| .github/workflows/cross-browser-testing.yml | Changes triggers to workflow_call / workflow_dispatch only |
| .github/workflows/cross-browser-testing-beta.yml | Changes triggers to workflow_call / workflow_dispatch only |
| .github/workflows/android-bridge-tests.yml | Changes trigger to workflow_call |
Files not reviewed (2)
- kits/adobe/packages/AdobeClient/package-lock.json: Language not supported
- kits/adobe/packages/AdobeServer/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
- release.config.js: change prepareCmd from 'sh' to 'bash' so set -eo pipefail and process substitutions (< <(...)) don't fail under POSIX sh - scripts/release.sh: guard the first git commit with 'git diff --cached --quiet ||' to avoid set -e aborting when npm run build produces no dist changes Addresses Copilot review comments on PR #1210. #agentic
There was a problem hiding this comment.
Pull request overview
This PR updates the Web SDK monorepo release pipeline to also build/test/publish kit packages under kits/, and adjusts kit package manifests and CI workflows to support the new multi-package flow.
Changes:
- Extend
scripts/release.shto build kit bundles, stagedist/outputs, and align kit versions to the SDK release version. - Update semantic-release configuration to support the new release flow (rules + prepare command + committed assets).
- Update kit
package.jsonpublish metadata and adjust CI workflows to test kits against a locally packed SDK artifact; add a post-release step to refresh kit lockfiles.
Reviewed changes
Copilot reviewed 40 out of 42 changed files in this pull request and generated 30 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/release.sh | Adds arg validation and builds/commits kit bundles + bumps kit versions during release preparation |
| release.config.js | Updates release rules, runs prepare script via bash, and broadens git assets to include all package manifests/locks |
| kits/matrix.json | Updates kit matrix entries (notably GA4/Adobe) to point at specific package subpaths |
| kits/twitter/package.json | Adds ESM/IIFE entries and module field for Twitter kit |
| kits/taplytics/package.json | Adds ESM/IIFE entries and module field for Taplytics kit |
| kits/simplereach/package.json | Adds ESM/IIFE entries and module field for SimpleReach kit |
| kits/rokt/package.json | Adds ESM entry and module field for Rokt kit |
| kits/optimizely/package.json | Adds ESM/IIFE entries and module field for Optimizely kit |
| kits/onetrust/package.json | Adds ESM/IIFE entries and module field for OneTrust kit |
| kits/mixpanel/mixpanel-2/package.json | Adds ESM/IIFE entries and module field for Mixpanel v2 kit |
| kits/localytics/localytics-4/package.json | Adds ESM/IIFE entries and module field for Localytics v4 kit |
| kits/leanplum/leanplum-1/package.json | Adds ESM/IIFE entries and module field for Leanplum v1 kit |
| kits/kissmetrics/package.json | Adds ESM/IIFE entries and module field for KissMetrics kit |
| kits/intercom/package.json | Adds ESM/IIFE entries and module field for Intercom kit |
| kits/inspectlet/package.json | Adds ESM/IIFE entries and module field for Inspectlet kit |
| kits/id5/id5-1/package.json | Adds ESM/IIFE entries and module field for ID5 v1 kit |
| kits/heap/package.json | Adds ESM/IIFE entries and module field for Heap kit |
| kits/google-tag-manager/package.json | Adds ESM/IIFE entries and module field for GTM kit |
| kits/google-analytics-4/packages/GA4Client/package.json | Adds ESM entry and module field; fixes files entry filename |
| kits/google-analytics-4/packages/GA4Server/package.json | Adds ESM entry and module field |
| kits/facebook/package.json | Adds missing IIFE file to published files list |
| kits/dynamic-yield/package.json | Adds ESM/IIFE entries and module field for Dynamic Yield kit |
| kits/doubleclick/package.json | Adds ESM/IIFE entries and module field for DoubleClick kit |
| kits/device-match/package.json | Adds ESM/IIFE entries and module field for Device Match kit |
| kits/criteo/package.json | Adds ESM/IIFE entries and module field for Criteo kit |
| kits/braze/braze-5/package.json | Adds missing IIFE file to published files list |
| kits/braze/braze-4/package.json | Adds ESM/IIFE entries and module field for Braze v4 kit |
| kits/braze/braze-3/package.json | Adds ESM/IIFE entries and module field for Braze v3 kit |
| kits/bingads/package.json | Adds ESM/IIFE entries and module field for Bing Ads kit |
| kits/adwords/package.json | Adds ESM/IIFE entries and module field; fixes files typo |
| kits/adobe/package.json | Marks Adobe umbrella package as private |
| kits/adobe/packages/AdobeClient/package.json | Adds publish metadata + build/test scripts and module field for Adobe Client kit |
| kits/adobe/packages/AdobeClient/package-lock.json | Adds/updates lockfile for Adobe Client package |
| kits/adobe/packages/AdobeServer/package.json | Adds publish metadata + build/test scripts and module field for Adobe Server kit |
| kits/adobe/packages/AdobeServer/package-lock.json | Adds lockfile for Adobe Server package |
| kits/adobe-target/package.json | Fixes files entry and adds ESM/IIFE entries + module field |
| .github/workflows/staging-step-1.yml | Packs SDK for kit tests, tests kits against packed SDK, adds post-release lockfile refresh job |
| .github/workflows/release.yml | Removes legacy standalone release workflow |
| .github/workflows/pull-request.yml | Adds BrowserStack and Android bridge workflows to PR checks |
| .github/workflows/cross-browser-testing.yml | Switches to workflow_call so it runs via the PR workflow |
| .github/workflows/cross-browser-testing-beta.yml | Switches to workflow_call so it runs via the PR workflow |
| .github/workflows/android-bridge-tests.yml | Switches to workflow_call so it runs via the PR workflow |
Files not reviewed (2)
- kits/adobe/packages/AdobeClient/package-lock.json: Language not supported
- kits/adobe/packages/AdobeServer/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
20 kits had module/files entries pointing to .esm.js artifacts that were never generated. Added a third ESM build entry to each rollup config following the braze-5 reference pattern. Kits with the web-kit-wrapper pattern (GA4Client, GA4Server, adobe-target, doubleclick, optimizely) also include productionBuilds.esm in the ENVIRONMENT selector. Addresses Copilot review comments on PR #1210. #agentic
…erver The Adobe build pipeline uses .esm.js as a temporary rollup input that is deleted after the build, so no real ESM artifact is ever produced. Removed the dist/...esm.js entry from files[] and the module field from both AdobeClient and AdobeServer package.json to avoid advertising a broken ESM entrypoint on publish. #agentic
Also exclude .claude/ worktrees from prettier checks. #agentic
There was a problem hiding this comment.
Pull request overview
This PR consolidates and modernizes the Web SDK release process to build and publish kit packages from the monorepo (kits/), adding ESM artifacts and updating CI workflows to test and release kits alongside the core SDK.
Changes:
- Extend the release script and semantic-release config to build/commit kit dist outputs and align kit versions with the SDK release version.
- Add ESM (and missing IIFE) bundle outputs and metadata across many kit packages (rollup + package.json updates).
- Update GitHub Actions workflows to support kit testing against a locally packed SDK and add post-release kit lockfile refresh automation.
Reviewed changes
Copilot reviewed 61 out of 63 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/release.sh | Builds core dist + kit bundles, stages/commits dist outputs, and bumps kit versions during release. |
| release.config.js | Adjusts semantic-release rules and broadens committed assets to cover monorepo packages/locks. |
| kits/matrix.json | Splits GA4 and Adobe entries into client/server package paths for the new monorepo layout. |
| kits/twitter/rollup.config.js | Adds ESM output build. |
| kits/twitter/package.json | Publishes common/esm/iife artifacts and sets module. |
| kits/taplytics/rollup.config.js | Adds ESM output build. |
| kits/taplytics/package.json | Publishes common/esm/iife artifacts and sets module. |
| kits/simplereach/rollup.config.js | Adds ESM output build. |
| kits/simplereach/package.json | Publishes common/esm/iife artifacts and sets module. |
| kits/rokt/rollup.config.js | Adds ESM output build. |
| kits/rokt/package.json | Publishes common/esm/iife artifacts and sets module. |
| kits/optimizely/rollup.config.js | Adds ESM production build variant. |
| kits/optimizely/package.json | Publishes common/esm/iife artifacts and sets module. |
| kits/onetrust/package.json | Adds ESM/iife artifacts and module metadata. |
| kits/mixpanel/mixpanel-2/rollup.config.js | Adds ESM output build. |
| kits/mixpanel/mixpanel-2/package.json | Publishes common/esm/iife artifacts and sets module. |
| kits/localytics/localytics-4/rollup.config.js | Adds ESM output build. |
| kits/localytics/localytics-4/package.json | Publishes common/esm/iife artifacts and sets module. |
| kits/leanplum/leanplum-1/rollup.config.js | Adds ESM output build. |
| kits/leanplum/leanplum-1/package.json | Publishes common/esm/iife artifacts and sets module. |
| kits/kissmetrics/package.json | Adds ESM/iife artifacts and module metadata. |
| kits/intercom/rollup.config.js | Adds ESM output build. |
| kits/intercom/package.json | Publishes common/esm/iife artifacts and sets module. |
| kits/inspectlet/package.json | Adds ESM/iife artifacts and module metadata. |
| kits/id5/id5-1/package.json | Adds ESM/iife artifacts and module metadata. |
| kits/heap/package.json | Adds ESM/iife artifacts and module metadata. |
| kits/google-tag-manager/package.json | Adds ESM/iife artifacts and module metadata. |
| kits/google-analytics-4/packages/GA4Server/rollup.config.js | Adds ESM output build. |
| kits/google-analytics-4/packages/GA4Server/package.json | Publishes common+esm artifacts and sets module. |
| kits/google-analytics-4/packages/GA4Client/rollup.config.js | Adds ESM production build variant. |
| kits/google-analytics-4/packages/GA4Client/package.json | Publishes common+esm artifacts and sets module. |
| kits/facebook/package.json | Adds missing IIFE artifact to published files. |
| kits/dynamic-yield/rollup.config.js | Adds ESM output build. |
| kits/dynamic-yield/package.json | Publishes common/esm/iife artifacts and sets module. |
| kits/doubleclick/rollup.config.js | Adds ESM output build. |
| kits/doubleclick/package.json | Publishes common/esm/iife artifacts and sets module. |
| kits/device-match/rollup.config.js | Adds ESM output build. |
| kits/device-match/package.json | Publishes common/esm/iife artifacts and sets module. |
| kits/criteo/rollup.config.js | Adds ESM output build. |
| kits/criteo/package.json | Publishes common/esm/iife artifacts and sets module. |
| kits/braze/braze-5/package.json | Adds missing IIFE artifact to published files. |
| kits/braze/braze-4/rollup.config.js | Adds ESM output build. |
| kits/braze/braze-4/package.json | Publishes common/esm/iife artifacts and sets module. |
| kits/braze/braze-3/rollup.config.js | Adds ESM output build. |
| kits/braze/braze-3/package.json | Publishes common/esm/iife artifacts and sets module. |
| kits/bingads/rollup.config.js | Adds ESM output build. |
| kits/bingads/package.json | Publishes common/esm/iife artifacts and sets module. |
| kits/adwords/rollup.config.js | Adds ESM output build. |
| kits/adwords/package.json | Publishes common/esm/iife artifacts and sets module (and fixes dist filename typo). |
| kits/adobe/packages/AdobeServer/package.json | Converts to monorepo-driven build/test scripts and publishes common+iife outputs. |
| kits/adobe/packages/AdobeServer/package-lock.json | Adds/updates lockfile for the AdobeServer package. |
| kits/adobe/packages/AdobeClient/package.json | Converts to monorepo-driven build/test scripts and publishes common+iife outputs. |
| kits/adobe/packages/AdobeClient/package-lock.json | Updates lockfile format/version for the AdobeClient package. |
| kits/adobe/package.json | Marks the Adobe aggregator package as private. |
| kits/adobe-target/rollup.config.js | Adds ESM production build variant. |
| kits/adobe-target/package.json | Publishes common/esm/iife artifacts and sets module (and fixes dist filename typo). |
| .github/workflows/staging-step-1.yml | Builds SDK tarball for kit tests, runs kit tests against packed SDK, publishes kits, and refreshes kit lockfiles post-release. |
| .github/workflows/release.yml | Removes the legacy release workflow. |
| .github/workflows/pull-request.yml | Adds BrowserStack and Android bridge tests via reusable workflows. |
| .github/workflows/cross-browser-testing.yml | Changes triggers to workflow_call/workflow_dispatch only. |
| .github/workflows/cross-browser-testing-beta.yml | Changes triggers to workflow_call/workflow_dispatch only. |
| .github/workflows/android-bridge-tests.yml | Changes trigger to workflow_call. |
Files not reviewed (2)
- kits/adobe/packages/AdobeClient/package-lock.json: Language not supported
- kits/adobe/packages/AdobeServer/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
.github/workflows/staging-step-1.yml
Outdated
Comment on lines
+499
to
+505
| jq -r '.[].local_path' kits/matrix.json | while read KIT_PATH; do | ||
| if [ -f "$KIT_PATH/package.json" ] && [ -f "$KIT_PATH/package-lock.json" ]; then | ||
| echo "Refreshing lock file for $KIT_PATH..." | ||
| (cd "$KIT_PATH" && npm install --package-lock-only) || true | ||
| fi | ||
| done | ||
|
|
Comment on lines
+16
to
+23
| echo '---------- Begin build kit bundles ----------' | ||
| if [ -f kits/matrix.json ]; then | ||
| jq -r '.[].local_path' kits/matrix.json | while read KIT_PATH; do | ||
| npm pkg set version="$VERSION" --prefix "$KIT_PATH" | ||
| echo "Updated $KIT_PATH/package.json to $VERSION" | ||
| done | ||
| while IFS= read -r KIT_PATH; do | ||
| echo "Installing dependencies for $KIT_PATH..." | ||
| npm ci --prefix "$KIT_PATH" | ||
| echo "Building $KIT_PATH..." | ||
| npm run build --prefix "$KIT_PATH" | ||
| done < <(jq -r '.[].local_path' kits/matrix.json) |
…ectlet, onetrust Also harden staging-step-1 kit lock-file loop with IFS= read -r. #agentic
There was a problem hiding this comment.
Pull request overview
This PR updates the Web SDK monorepo release process to build, version-bump, test, and publish kit packages (under kits/) alongside the core SDK, including adding ESM artifacts/metadata for many kits and updating CI workflows to support the new flow.
Changes:
- Extended the release script and semantic-release config to build/stage kit bundles and align kit package versions with the core SDK release version.
- Added ESM Rollup outputs and updated kit
package.jsonmetadata (files,module) to publish ESM/IIFE artifacts where applicable. - Updated GitHub Actions workflows to run kit tests against a locally packed SDK, adjust workflow triggers, and add post-release kit lockfile refresh automation.
Reviewed changes
Copilot reviewed 67 out of 69 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/release.sh | Builds core + kits, stages kit dist/, bumps kit versions, and commits release artifacts. |
| release.config.js | Updates semantic-release rules, uses bash for prepare, and broadens committed release assets to multi-package scope. |
| kits/twitter/rollup.config.js | Adds ESM bundle output for the Twitter kit. |
| kits/twitter/package.json | Publishes ESM/IIFE outputs via files and adds module entry. |
| kits/taplytics/rollup.config.js | Adds ESM bundle output for the Taplytics kit. |
| kits/taplytics/package.json | Publishes ESM/IIFE outputs via files and adds module entry. |
| kits/simplereach/rollup.config.js | Adds ESM bundle output for the SimpleReach kit. |
| kits/simplereach/package.json | Publishes ESM/IIFE outputs via files and adds module entry. |
| kits/rokt/rollup.config.js | Adds ESM bundle output for the Rokt kit. |
| kits/rokt/package.json | Adds ESM artifact to files and sets module entry. |
| kits/optimizely/rollup.config.js | Adds ESM build variant for production builds. |
| kits/optimizely/package.json | Publishes ESM/IIFE outputs via files and adds module entry. |
| kits/onetrust/rollup.config.js | Adds ESM bundle output for the OneTrust kit. |
| kits/onetrust/package.json | Publishes ESM/IIFE outputs via files and adds module entry. |
| kits/mixpanel/mixpanel-2/rollup.config.js | Adds ESM bundle output for Mixpanel v2 kit. |
| kits/mixpanel/mixpanel-2/package.json | Publishes ESM/IIFE outputs via files and adds module entry. |
| kits/matrix.json | Splits GA4 and Adobe entries into distinct client/server package paths. |
| kits/localytics/localytics-4/rollup.config.js | Adds ESM bundle output for Localytics v4 kit. |
| kits/localytics/localytics-4/package.json | Publishes ESM/IIFE outputs via files and adds module entry. |
| kits/leanplum/leanplum-1/rollup.config.js | Adds ESM bundle output for Leanplum v1 kit. |
| kits/leanplum/leanplum-1/package.json | Publishes ESM/IIFE outputs via files and adds module entry. |
| kits/kissmetrics/rollup.config.js | Adds ESM bundle output for Kissmetrics kit. |
| kits/kissmetrics/package.json | Publishes ESM/IIFE outputs via files and adds module entry. |
| kits/intercom/rollup.config.js | Adds ESM bundle output for Intercom kit. |
| kits/intercom/package.json | Publishes ESM/IIFE outputs via files and adds module entry. |
| kits/inspectlet/rollup.config.js | Adds ESM bundle output for Inspectlet kit. |
| kits/inspectlet/package.json | Publishes ESM/IIFE outputs via files and adds module entry. |
| kits/id5/id5-1/rollup.config.js | Adds ESM build variant for production builds. |
| kits/id5/id5-1/package.json | Publishes ESM/IIFE outputs via files and adds module entry. |
| kits/heap/rollup.config.js | Adds ESM build variant for production builds. |
| kits/heap/package.json | Publishes ESM/IIFE outputs via files and adds module entry. |
| kits/google-tag-manager/rollup.config.js | Adds ESM build variant for production builds. |
| kits/google-tag-manager/package.json | Publishes ESM/IIFE outputs via files and adds module entry. |
| kits/google-analytics-4/packages/GA4Server/rollup.config.js | Adds ESM output for GA4 Server kit. |
| kits/google-analytics-4/packages/GA4Server/package.json | Publishes GA4 Server ESM artifact and adds module entry. |
| kits/google-analytics-4/packages/GA4Client/rollup.config.js | Adds ESM build variant for GA4 Client production builds. |
| kits/google-analytics-4/packages/GA4Client/package.json | Fixes files entry, adds ESM artifact, and adds module entry. |
| kits/facebook/package.json | Adds missing IIFE artifact to files. |
| kits/dynamic-yield/rollup.config.js | Adds ESM bundle output for Dynamic Yield kit. |
| kits/dynamic-yield/package.json | Publishes ESM/IIFE outputs via files and adds module entry. |
| kits/doubleclick/rollup.config.js | Adds ESM bundle output for DoubleClick kit. |
| kits/doubleclick/package.json | Publishes ESM/IIFE outputs via files and adds module entry. |
| kits/device-match/rollup.config.js | Adds ESM bundle output for Device Match kit. |
| kits/device-match/package.json | Publishes ESM/IIFE outputs via files and adds module entry. |
| kits/criteo/rollup.config.js | Adds ESM bundle output for Criteo kit. |
| kits/criteo/package.json | Publishes ESM/IIFE outputs via files and adds module entry. |
| kits/braze/braze-5/package.json | Adds missing IIFE artifact to files. |
| kits/braze/braze-4/rollup.config.js | Adds ESM bundle output for Braze v4 kit. |
| kits/braze/braze-4/package.json | Publishes ESM/IIFE outputs via files and adds module entry. |
| kits/braze/braze-3/rollup.config.js | Adds ESM bundle output for Braze v3 kit. |
| kits/braze/braze-3/package.json | Publishes ESM/IIFE outputs via files and adds module entry. |
| kits/bingads/rollup.config.js | Adds ESM bundle output for Bing Ads kit. |
| kits/bingads/package.json | Publishes ESM/IIFE outputs via files and adds module entry. |
| kits/adwords/rollup.config.js | Adds ESM bundle output for AdWords kit. |
| kits/adwords/package.json | Fixes files typo and publishes ESM/IIFE outputs with module entry. |
| kits/adobe/packages/AdobeServer/package.json | Adds files/browser, and routes build/test to the Adobe kit workspace scripts. |
| kits/adobe/packages/AdobeServer/package-lock.json | Adds lockfile for Adobe Server package. |
| kits/adobe/packages/AdobeClient/package.json | Adds files/browser, and routes build/test to the Adobe kit workspace scripts. |
| kits/adobe/packages/AdobeClient/package-lock.json | Updates lockfile format/version for Adobe Client package. |
| kits/adobe/package.json | Marks the Adobe aggregate package as private. |
| kits/adobe-target/rollup.config.js | Adds ESM build variant for production builds. |
| kits/adobe-target/package.json | Fixes files entry, adds ESM/IIFE outputs, and adds module entry. |
| .prettierignore | Fixes kit ignore path formatting and adds .claude/ ignore. |
| .github/workflows/staging-step-1.yml | Packs local SDK for kit tests, runs kits against it, adds post-release lockfile refresh + cleanup dependency updates. |
| .github/workflows/release.yml | Removes the legacy release workflow. |
| .github/workflows/pull-request.yml | Adds Android bridge and BrowserStack workflows into PR checks. |
| .github/workflows/cross-browser-testing.yml | Converts to reusable workflow (workflow_call) instead of push/PR triggers. |
| .github/workflows/cross-browser-testing-beta.yml | Converts to reusable workflow (workflow_call) instead of push triggers. |
| .github/workflows/android-bridge-tests.yml | Converts to reusable workflow (workflow_call). |
Files not reviewed (2)
- kits/adobe/packages/AdobeClient/package-lock.json: Language not supported
- kits/adobe/packages/AdobeServer/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
+495
to
+496
| run: sleep 60 | ||
|
|
…mpTaplyticsKit Pre-existing typo in all three build entries (iife, cjs, esm). #agentic
|
| node-version: 24.x | ||
| registry-url: 'https://registry.npmjs.org' | ||
|
|
||
| - name: Wait for npm registry propagation |
Collaborator
There was a problem hiding this comment.
What's the point of waiting for NPM to propogate when there's no previous npm step?
| - name: Wait for npm registry propagation | ||
| run: sleep 60 | ||
|
|
||
| - name: Refresh kit lock files |
Collaborator
There was a problem hiding this comment.
I don't think we should be automatically touching package lock files in such a way. We should be treating them as static since it may affect developers down the line.
Contributor
Author
There was a problem hiding this comment.
Will remove the package-lock file logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
What Has Changed
Checklist
Additional Notes
Reference Issue (For employees only. Ignore if you are an outside contributor)