Skip to content

ci: replace flaky hardcoded-secrets job with trufflehog-git in Trunk #746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamesnrokt merged 3 commits into from
Jul 30, 2026
+4 −3
Merged

ci: replace flaky hardcoded-secrets job with trufflehog-git in Trunk #746

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8a28c4b
ci: remove hardcoded secrets check from PR workflow
jamesnrokt Jul 30, 2026
361da68
ci: enable trufflehog-git to scan the commits a PR adds
jamesnrokt Jul 30, 2026
437b884
Merge branch 'main' into ci/remove-secrets-scan
jamesnrokt Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .github/workflows/pull-request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,6 @@ jobs:
uses: trunk-io/trunk-action@04ba50e7658c81db7356da96657e6e77f220bfa3 # v1.3.1
with:
check-mode: pull_request
pr-check-hadcoded-secrets:
Comment thread
jamesnrokt marked this conversation as resolved.
name: "Check PR for hardcoded secrets"
uses: mParticle/mparticle-workflows/.github/workflows/security-hardcoded-secrets.yml@main

instrumented-core:
uses: ./.github/workflows/instrumented-tests.yml
Expand Down
4 changes: 4 additions & 0 deletions .trunk/trunk.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,10 @@ lint:
- shellcheck@0.11.0
- shfmt@3.6.0
- trufflehog@3.90.6
# Scans the commits a PR adds (--since-commit ${upstream-ref}), which catches
# secrets that were committed and then removed later on the same branch --
# the working-tree scan above cannot see those.
- trufflehog-git@3.90.6
Comment thread
jamesnrokt marked this conversation as resolved.
- mparticle-api-key-check # Custom rule to prevent mParticle API keys from being committed
definitions:
- name: mparticle-api-key-check
Expand Down
Loading