fix(singular): raise singular-12 sample app minSdk to 21 - #745
Merged
Conversation
Singular's `api` dependency uses an open version range, so 12.15.0 was
picked up automatically. That release raised its own minSdk to 21, which
broke the sample app's manifest merge:
Manifest merger failed : uses-sdk:minSdkVersion 16 cannot be smaller
than version 21 declared in library [com.singular.sdk:singular_sdk:12.15.0]
`build-kits / Build singular-12` has failed on every PR since 2026-07-23
with no code change on our side.
Manifest merger only enforces minSdk compatibility for application
modules; library modules downgrade it to a warning. The sample app is the
sole application module in this kit, so it is the only thing that fails --
`singular-12:testRelease` and `bundleReleaseAar` both pass unchanged.
No externally visible change: sample apps are not published, the kit keeps
minSdkVersion 16, and the dependency range is untouched.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
PR SummaryLow Risk Overview The published singular-12 kit still declares Reviewed by Cursor Bugbot for commit a4d5dca. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
thomson-t
approved these changes
Jul 30, 2026
denischilik
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What
One line — the singular-12 Kotlin sample app's
minSdkgoes from 16 to 21.kits/singular/singular-12/example/example-kotlin/build.gradle applicationId 'com.mparticle.kits.singular.example.kotlin' - minSdk 16 + minSdk 21Why
build-kits / Build singular-12has failed on every PR since 2026-07-23 with no code change on our side — it currently blocks #742, #743, #744 and #722.The kit declares Singular with an open version range, so 12.15.0 was picked up automatically. That release raised its own
minSdkto 21:Manifest merger enforces
minSdkcompatibility only for application modules; library modules downgrade it to a warning. The sample app is the sole application module in this kit, so it is the only thing that can fail.Scope: sample app only
The job runs three Gradle steps. Steps 1–2 already pass; only step 3 fails:
publishMavenPublicationToMavenLocalsingular-12:testReleaseexample-kotlin:assembleDebugNo externally visible change
minSdkVersion 16— untouched.Verified the publishable artifact is unaffected:
Verification
Reproduced the CI steps locally (JDK 17), using
--rerun-tasksto rule out Gradle caching:processDebugMainManifestminSdk 21(this PR)minSdk 16(control)Reviewer note
A customer on
minSdk16–20 who adds singular-12 will hit this same manifest merger error in their own build, because Singular is anapidependency and therefore transitive in the published POM.This PR deliberately does not raise the published kit's
minSdk— that is a breaking change and warrants its own decision. Flagging so it is tracked rather than forgotten.🤖 Generated with Claude Code