Skip to content

Conversation

@lukier
Copy link
Contributor

@lukier lukier commented Jan 18, 2025

I couldn't build for ESP32-S3 last night, so I fixed the code in a couple of places.

@kdschlosser
Copy link
Collaborator

I made some comments on the changes that are proposed.

I had made changes before I realized that I had forgotten to add the source file to the cmake script which was what was causing some of the issues. I couldn't understand why there were some of the issues and once I found out what the issue were being caused by I did not revert any of the changes I made as sleep was more important at the time.

@lukier
Copy link
Contributor Author

lukier commented Jan 19, 2025

Oh sorry, I've just noticed that by the time I've created the pull-request you've already started fixing those issues.

Sorry for the confusion. You can close this PR if you want.

@kdschlosser
Copy link
Collaborator

No No. correct those couple of things and I will merge it because I do want to revert some of it back to the way it was originally. You spent the time to do the work I basically didn't want to do. LOL.

Just need to update a few things so it can be merged.

@lukier
Copy link
Contributor Author

lukier commented Jan 19, 2025

No No. correct those couple of things and I will merge it because I do want to revert some of it back to the way it was originally. You spent the time to do the work I basically didn't want to do. LOL.

Just need to update a few things so it can be merged.

No problem, but I don't see any comments in the code review, where are they?

@kdschlosser
Copy link
Collaborator

I was also messing around with the CI when I was making the changes I was making... It was taking too damned long for the CI to run. I changed it so instead of it using GitHub's servers for the CI it is using my server to run the CI. It is now able to run the builds in 4 minutes when it was taking 14 minutes to complete.

Copy link
Collaborator

@kdschlosser kdschlosser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to click on the finish button for them to show up.

@kdschlosser
Copy link
Collaborator

It's running the CI now.

@kdschlosser kdschlosser merged commit 36c0759 into lvgl-micropython:main Jan 19, 2025
5 checks passed
@lukier lukier deleted the fix-for-esp32-s3 branch January 19, 2025 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants