Skip to content

[WRONG BRANCH] fix(codex): preserve external history on async restore - #10

Closed
luvs01 wants to merge 1 commit into
mainfrom
codex/propose-fix-for-history-retagging-issue
Closed

[WRONG BRANCH] fix(codex): preserve external history on async restore#10
luvs01 wants to merge 1 commit into
mainfrom
codex/propose-fix-for-history-retagging-issue

Conversation

@luvs01

@luvs01 luvs01 commented Aug 7, 2026

Copy link
Copy Markdown
Owner

Motivation

  • The async restoreNativeCodexAsync() wrapper was scheduling a history restore job unconditionally after calling the synchronous restore path, which allowed the history worker to retag routed threads back to the native/OpenAI provider even when the synchronous restore preserved an external provider; this change prevents that unintended retagging.

Description

  • Add an internal restoreNativeCodexCore() that returns an additional restoreHistory boolean indicating whether the async wrapper should run the history worker, and keep a thin public restoreNativeCodex() shim that preserves the original return shape.
  • Update restoreNativeCodexAsync() to call the core and return early when restoreHistory is false so the history worker is not scheduled for externally-preserved providers.
  • Adjust source-level test asserting history ownership to reference the new restoreNativeCodexCore() symbol.
  • Add an integration regression test that runs the async restore path and asserts the DB rows and rollout metadata remain unchanged for an external provider.

Testing

  • Ran bun run typecheck, which succeeded.
  • Ran bun run privacy:scan, which succeeded.
  • Ran git diff --check and committed the patch as fix(codex): preserve external history on async restore.
  • Attempted bun test tests/codex-history-job.test.ts tests/codex-inject-integration.test.ts, but the test run was blocked by the environment's Bun/runtime mismatch (installed Bun 1.2.14 fails due to node:zlib not exporting zstdDecompressSync), causing the integration subprocess-based tests to produce no usable output; the new regression test is present and should pass in CI or a local environment with a compatible Bun/runtime.

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@luvs01, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 13 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: ccb48bf2-2794-4c08-9482-3aa3cabc05f2

📥 Commits

Reviewing files that changed from the base of the PR and between 2468502 and f61de72.

📒 Files selected for processing (3)
  • src/codex/inject.ts
  • tests/codex-history-job.test.ts
  • tests/codex-inject-integration.test.ts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the bug Something isn't working label Aug 7, 2026
@github-actions github-actions Bot changed the title fix(codex): preserve external history on async restore [WRONG BRANCH] fix(codex): preserve external history on async restore Aug 7, 2026
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

⏳ DRAFT

  • wrong target branch (main); retarget to dev.

What to do

  • Retarget this PR to dev — all contributions go to dev.

Its title has been prefixed with [WRONG BRANCH].
This pull request was already a draft. Its draft status will be preserved after every issue above is resolved.

@github-actions
github-actions Bot marked this pull request as draft August 7, 2026 05:33

luvs01 commented Aug 7, 2026

Copy link
Copy Markdown
Owner Author

Closing as already covered upstream. Current restoreNativeCodexAsync exits for an external provider before scheduling the history worker, through the lidge-jun#998/lidge-jun#1106 integration.

@luvs01 luvs01 closed this Aug 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aardvark bug Something isn't working codex

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant