Repository navigation
Fix ucode test fixtures for Phoenix, fetch firmware in CI, README fixes - #1
Merged
Merged
Conversation
- tests: use Phoenix firmware names (gc_11_0_1_*, sdma_6_0_1) instead of Navi 32 (gc_11_0_3_*, sdma_6_0_3); expected SDMA sizes already match 6.0.1. - tests: skip firmware-based cases when fixtures are absent, fail if REQUIRE_FIXTURES is set (CI sets it). - tools/fetch_test_firmware.sh + `make fixtures`: download blobs from upstream linux-firmware instead of committing them; ignore tests/fixtures/. - CI: fetch fixtures before `make test`. - README (EN/RU): build step for mtlprobe, safe revert order with `kmutil install --update-all`, drop Apple Pay/Touch ID line, `make fixtures`. - fresh.sh: require MAC_IP instead of a hardcoded LAN address. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011vNcz12yj5f6MvZFQ7rrp8
git.kernel.org rejected the CI runner; try the official GitLab mirror first, then kernel.org, and reject HTML pages saved in place of firmware. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011vNcz12yj5f6MvZFQ7rrp8
The script uses bash arrays; `sh` is dash on Ubuntu runners and failed with a syntax error (exit 2). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011vNcz12yj5f6MvZFQ7rrp8
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011vNcz12yj5f6MvZFQ7rrp8
Phoenix (GC 11.0.1) ships gc_11_0_1_{pfp,me,mec}.bin with a v1.0 header
(F32, rs64_enable == false). The extractor only accepted RS64 v2.0 and
returned no payloads for real Phoenix firmware. Return one payload typed
CP_PFP / CP_ME / CP_MEC for v1.x, as tools/phxctl/bringup5.sh loads them.
Tests: check the real Phoenix CP files as v1.0 single payloads, and keep
RS64 v2.0 coverage on a synthetic header.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011vNcz12yj5f6MvZFQ7rrp8
Owner
Author
|
CI зелёный. Что добавилось после открытия PR:
Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Что меняется
gc_11_0_3_*,sdma_6_0_3) на Phoenix (gc_11_0_1_*,sdma_6_0_1) — те же файлы, что грузитtools/phxctl/bringup5.sh. Ожидаемые размеры SDMA (17408/16896) уже соответствовали 6.0.1.REQUIRE_FIXTURES=1(CI) — падают.make fixtures/tools/fetch_test_firmware.shскачивает блобы из upstream linux-firmware вместо коммита в репо;tests/fixtures/в.gitignore.make test.mtlprobe, безопасный порядок отката (kmutil install --update-allдо возврата AMFI), убран пункт про Apple Pay/Touch ID,make fixtures.fresh.sh: требуетMAC_IPвместо захардкоженного адреса.Проверка
make testлокально проходит (firmware-тесты пропущены — фикстуры из моего окружения скачать нельзя).Не входит
GPL-2.0-onlyиGPL-2.0-only OR MITв LICENSE.Generated by Claude Code