chore(deps): move @expo/config-plugins to devDependencies#80
Merged
Conversation
Move @expo/config-plugins from runtime dependency to devDependency (for typechecking the plugin source) and add expo as an optional peer dependency. Expo apps already bundle @expo/config-plugins, so the plugin resolves it from the consumer at prebuild time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@expo/config-pluginswas listed as a runtimedependency, but it's only used by the Expo config plugin (plugin/src) that runs at prebuild time. Expo apps already bundle@expo/config-pluginsviaexpo, so shipping it as a runtime dep risks duplicate/mismatched versions in consumers.@expo/config-pluginstodevDependencies(for typechecking the plugin source).expoas an optional peer dependency.Type of Change
Test Plan
yarn typecheckpassesyarn build:pluginsucceeds@expo/config-pluginsfrom the consumer (Expo app) at prebuild timeChecklist