Skip to content

fix(ios): make event emit() templates compatible with RN 0.85+ #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lodev09 merged 1 commit into from
May 26, 2026
Merged

fix(ios): make event emit() templates compatible with RN 0.85+ #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ios/events/CameraIdleEvent.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,10 @@ struct CameraIdleEvent {
double zoom;
bool gesture;

template <typename Emitter>
void emit(const facebook::react::SharedEventEmitter &eventEmitter) const {
// Holder type is templated to bridge RN versions: SharedEventEmitter went
// from shared_ptr<const EventEmitter> to shared_ptr<EventEmitter> in 0.85.
template <typename Emitter, typename EventEmitterPtr>
void emit(const EventEmitterPtr &eventEmitter) const {
if (!eventEmitter)
return;
auto emitter = std::static_pointer_cast<Emitter const>(eventEmitter);
Expand Down
6 changes: 4 additions & 2 deletions ios/events/CameraMoveEvent.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,10 @@ struct CameraMoveEvent {
double zoom;
bool gesture;

template <typename Emitter>
void emit(const facebook::react::SharedEventEmitter &eventEmitter) const {
// Holder type is templated to bridge RN versions: SharedEventEmitter went
// from shared_ptr<const EventEmitter> to shared_ptr<EventEmitter> in 0.85.
template <typename Emitter, typename EventEmitterPtr>
void emit(const EventEmitterPtr &eventEmitter) const {
if (!eventEmitter)
return;
auto emitter = std::static_pointer_cast<Emitter const>(eventEmitter);
Expand Down
6 changes: 4 additions & 2 deletions ios/events/CirclePressEvent.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,10 @@ namespace luggmaps {
namespace events {

struct CirclePressEvent {
template <typename Emitter>
static void emit(const facebook::react::SharedEventEmitter &eventEmitter) {
// Holder type is templated to bridge RN versions: SharedEventEmitter went
// from shared_ptr<const EventEmitter> to shared_ptr<EventEmitter> in 0.85.
template <typename Emitter, typename EventEmitterPtr>
static void emit(const EventEmitterPtr &eventEmitter) {
if (!eventEmitter)
return;
auto emitter = std::static_pointer_cast<Emitter const>(eventEmitter);
Expand Down
6 changes: 4 additions & 2 deletions ios/events/GroundOverlayPressEvent.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,10 @@ namespace luggmaps {
namespace events {

struct GroundOverlayPressEvent {
template <typename Emitter>
static void emit(const facebook::react::SharedEventEmitter &eventEmitter) {
// Holder type is templated to bridge RN versions: SharedEventEmitter went
// from shared_ptr<const EventEmitter> to shared_ptr<EventEmitter> in 0.85.
template <typename Emitter, typename EventEmitterPtr>
static void emit(const EventEmitterPtr &eventEmitter) {
if (!eventEmitter)
return;
auto emitter = std::static_pointer_cast<Emitter const>(eventEmitter);
Expand Down
6 changes: 4 additions & 2 deletions ios/events/LongPressEvent.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,10 @@ struct LongPressEvent {
double x;
double y;

template <typename Emitter>
void emit(const facebook::react::SharedEventEmitter &eventEmitter) const {
// Holder type is templated to bridge RN versions: SharedEventEmitter went
// from shared_ptr<const EventEmitter> to shared_ptr<EventEmitter> in 0.85.
template <typename Emitter, typename EventEmitterPtr>
void emit(const EventEmitterPtr &eventEmitter) const {
if (!eventEmitter)
return;
auto emitter = std::static_pointer_cast<Emitter const>(eventEmitter);
Expand Down
18 changes: 12 additions & 6 deletions ios/events/MarkerDragEvent.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,10 @@ struct MarkerDragStartEvent {
double x;
double y;

template <typename Emitter>
void emit(const facebook::react::SharedEventEmitter &eventEmitter) const {
// Holder type is templated to bridge RN versions: SharedEventEmitter went
// from shared_ptr<const EventEmitter> to shared_ptr<EventEmitter> in 0.85.
template <typename Emitter, typename EventEmitterPtr>
void emit(const EventEmitterPtr &eventEmitter) const {
if (!eventEmitter)
return;
auto emitter = std::static_pointer_cast<Emitter const>(eventEmitter);
Expand All @@ -31,8 +33,10 @@ struct MarkerDragChangeEvent {
double x;
double y;

template <typename Emitter>
void emit(const facebook::react::SharedEventEmitter &eventEmitter) const {
// Holder type is templated to bridge RN versions: SharedEventEmitter went
// from shared_ptr<const EventEmitter> to shared_ptr<EventEmitter> in 0.85.
template <typename Emitter, typename EventEmitterPtr>
void emit(const EventEmitterPtr &eventEmitter) const {
if (!eventEmitter)
return;
auto emitter = std::static_pointer_cast<Emitter const>(eventEmitter);
Expand All @@ -51,8 +55,10 @@ struct MarkerDragEndEvent {
double x;
double y;

template <typename Emitter>
void emit(const facebook::react::SharedEventEmitter &eventEmitter) const {
// Holder type is templated to bridge RN versions: SharedEventEmitter went
// from shared_ptr<const EventEmitter> to shared_ptr<EventEmitter> in 0.85.
template <typename Emitter, typename EventEmitterPtr>
void emit(const EventEmitterPtr &eventEmitter) const {
if (!eventEmitter)
return;
auto emitter = std::static_pointer_cast<Emitter const>(eventEmitter);
Expand Down
6 changes: 4 additions & 2 deletions ios/events/MarkerPressEvent.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,10 @@ struct MarkerPressEvent {
double x;
double y;

template <typename Emitter>
void emit(const facebook::react::SharedEventEmitter &eventEmitter) const {
// Holder type is templated to bridge RN versions: SharedEventEmitter went
// from shared_ptr<const EventEmitter> to shared_ptr<EventEmitter> in 0.85.
template <typename Emitter, typename EventEmitterPtr>
void emit(const EventEmitterPtr &eventEmitter) const {
if (!eventEmitter)
return;
auto emitter = std::static_pointer_cast<Emitter const>(eventEmitter);
Expand Down
6 changes: 4 additions & 2 deletions ios/events/PolygonPressEvent.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,10 @@ namespace luggmaps {
namespace events {

struct PolygonPressEvent {
template <typename Emitter>
static void emit(const facebook::react::SharedEventEmitter &eventEmitter) {
// Holder type is templated to bridge RN versions: SharedEventEmitter went
// from shared_ptr<const EventEmitter> to shared_ptr<EventEmitter> in 0.85.
template <typename Emitter, typename EventEmitterPtr>
static void emit(const EventEmitterPtr &eventEmitter) {
if (!eventEmitter)
return;
auto emitter = std::static_pointer_cast<Emitter const>(eventEmitter);
Expand Down
6 changes: 4 additions & 2 deletions ios/events/PressEvent.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,10 @@ struct PressEvent {
double x;
double y;

template <typename Emitter>
void emit(const facebook::react::SharedEventEmitter &eventEmitter) const {
// Holder type is templated to bridge RN versions: SharedEventEmitter went
// from shared_ptr<const EventEmitter> to shared_ptr<EventEmitter> in 0.85.
template <typename Emitter, typename EventEmitterPtr>
void emit(const EventEmitterPtr &eventEmitter) const {
if (!eventEmitter)
return;
auto emitter = std::static_pointer_cast<Emitter const>(eventEmitter);
Expand Down
6 changes: 4 additions & 2 deletions ios/events/ReadyEvent.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,10 @@ namespace luggmaps {
namespace events {

struct ReadyEvent {
template <typename Emitter>
static void emit(const facebook::react::SharedEventEmitter &eventEmitter) {
// Holder type is templated to bridge RN versions: SharedEventEmitter went
// from shared_ptr<const EventEmitter> to shared_ptr<EventEmitter> in 0.85.
template <typename Emitter, typename EventEmitterPtr>
static void emit(const EventEmitterPtr &eventEmitter) {
if (!eventEmitter)
return;
auto emitter = std::static_pointer_cast<Emitter const>(eventEmitter);
Expand Down
6 changes: 4 additions & 2 deletions ios/events/TileOverlayPressEvent.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,10 @@ namespace luggmaps {
namespace events {

struct TileOverlayPressEvent {
template <typename Emitter>
static void emit(const facebook::react::SharedEventEmitter &eventEmitter) {
// Holder type is templated to bridge RN versions: SharedEventEmitter went
// from shared_ptr<const EventEmitter> to shared_ptr<EventEmitter> in 0.85.
template <typename Emitter, typename EventEmitterPtr>
static void emit(const EventEmitterPtr &eventEmitter) {
if (!eventEmitter)
return;
auto emitter = std::static_pointer_cast<Emitter const>(eventEmitter);
Expand Down
Loading