fix(tui-v2): detach tool subprocess stdin#678
Merged
Conversation
lsdefine
approved these changes
Jul 10, 2026
lsdefine
left a comment
Owner
There was a problem hiding this comment.
Reviewed the changes and targeted behavior. Approving for merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
code_runtool subprocesses from inheriting the TUI terminal stdin.!shellcommands.Why
On POSIX terminals, child processes that inherit fd 0 can race Textual for keyboard input while tools are running. This shows up most often on macOS/Linux with multiple active tui2 sessions as randomly swallowed letters, spaces, or Enter.
Notes
input=is provided.memory/checklist_helper.pyfrom fix(tui v2): stop tool subprocesses inheriting TTY stdin (multi-session key-eating on macOS/Linux) #656.Verification
PYTHONIOENCODING=utf-8 py -3.12 -m py_compile ga.py frontends/tuiapp_v2.pycode_runsmoke test: Python child sees stdin EOF (sys.stdin.read() == '') while stdout capture still works.