fix: wrap _turn_end_hooks iteration with list() to prevent RuntimeError#486
Merged
lsdefine merged 1 commit intoMay 26, 2026
Merged
Conversation
When a hook modifies _turn_end_hooks dict during iteration in turn_end_callback, Python raises RuntimeError: dictionary changed size during iteration. Wrapping .values() with list() creates a snapshot copy, preventing this error.
lsdefine
approved these changes
May 26, 2026
Owner
lsdefine
left a comment
lsdefine
left a comment
There was a problem hiding this comment.
Approved: small safe fix to snapshot hook values during iteration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a hook modifies
_turn_end_hooksdict during iteration inturn_end_callback, Python raisesRuntimeError: dictionary changed size during iteration.This fix wraps the
.values()call withlist()to create a snapshot of the hooks before iterating, preventing the RuntimeError.Changes:
ga.pyline 576:for hook in getattr(self.parent, '_turn_end_hooks', {}).values()→for hook in list(getattr(self.parent, '_turn_end_hooks', {}).values())