[simple_system] Add BaseIsa parameter - #2492
Open
mingiiiiiiii wants to merge 1 commit into
Open
Conversation
util/ibex_config.py emits --BaseIsa for every configuration, but the simple system core file does not declare it. Any build following the documented command in examples/simple_system/README.md therefore fails during argument parsing: fusesoc run lowrisc_ibex_ibex_simple_system_0: error: unrecognized arguments: --BaseIsa=ibex_pkg::BaseIsaRV32I The parameter was added to ibex_top.core and ibex_top_tracing.core when CHERIoT support landed, but the simple system example was not updated. Declare it the same way, so the example accepts the generated options again. The default is unchanged, so the elaborated design stays the same for existing builds. Signed-off-by: mingiiiiiiii <mingi1684@kookmin.ac.kr>
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document. By submitting this pull request comment, I am hereby confirming my acceptance of the terms of the CLA Document and my agreement to be legally bound by its terms. |
mingiiiiiiii
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
util/ibex_config.pyemits--BaseIsafor every configuration, butexamples/simple_system/ibex_simple_system.coredoes not declare it. The buildcommand documented in
examples/simple_system/README.mdtherefore fails duringargument parsing:
fusesoc --cores-root=. run --target=sim --setup --build
lowrisc:ibex:ibex_simple_system $(util/ibex_config.py small fusesoc_opts)
fusesoc run lowrisc_ibex_ibex_simple_system_0: error: unrecognized arguments:
--BaseIsa=ibex_pkg::BaseIsaRV32I
BaseIsawas added toibex_top.coreandibex_top_tracing.corewhen CHERIoTsupport landed, but the simple system example was not updated.
This declares it in the same way, using the same datatype, default and
description, and adds it to the target parameter list.
Testing
Against
upstream/master(34b0705):.vcfile contains-DBaseIsa=ibex_pkg::BaseIsaRV32I.The default is unchanged, so the elaborated design is identical for existing
builds.