Repository navigation
Conversation
Signed-off-by: aihop <4408344+hhyykk@users.noreply.github.com>
hhyykk
requested review from
huangruiteng,
loopx-agent and
songoow
as code owners
October 21, 2026 13:22
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a TypeScript effect has been dispatched, a Python JSON decoder failure must preserve uncertainty about the write. Excessive response nesting raised
RecursionError, which fell into the pre-sendRuntimeErrorstartup retry path: an actual TCP reproduction dispatched the same request twice and then reportedruntime_request_failed. Invalid UTF-8 in an inline response escaped the typed recovery contract too.Keep
ValueErrorandRecursionErrorbehind the existingruntime_response_ambiguouscontract for inline and private-file responses. Existing domain callers can then expose their original operation ID and receipt recovery. Request/response budgets, authentication, provider decisions and receipt/CAS rules remain unchanged.Validation:
todo_create_response_ambiguouswith the original operation ID, and recovers through the public CLI with one Todo and an unchanged provider revision. All 6 cases passed from source and again from independently installed wheel and sdist: 18 cases total. Installed runs used empty working directories, isolated runtimes and verified package/native source paths.Performance evidence is mixed and retained for owner review. A matched complete SQLite
todo listcommand used fresh Python processes, warm disposable managed runtimes and prepared bytecode. Initial 15-sample paired p50/p95: 285.9/300.1 ms → 280.0/318.9 ms. The p95 increase is 18.8 ms / 6.3%, exceeding the RFC's 5% threshold. A fixed, counterbalanced A/A/B control then ran 30 samples per arm: identical-main A/A p95 349.2/310.5 ms, candidate 315.5 ms (1.6% / 5.0 ms above the faster control). This demonstrates tail variability; it does not erase the original miss or waive its owner-review gate. No speedup or general performance qualification is claimed.Migration economics: this is a shared transport correctness repair, not a new language cutover. TypeScript retains all domain/transaction ownership; Python retains response IO/decoding. Existing transport product diff is +3/−2 LOC (net +1); there is no new bridge module, RPC, facade, cache, schema or provider change, and no claimed retirement of domain rules. The two existing decode paths now use the same failure contract. The shared production-scale/promotion fixtures are unchanged. Paired RFC text records this behavior.
Overlap check: latest main
973914e8cb713ee176737c95750aedb3072b9ea8; 50 open PR heads and 844 changed-file rows checked. #6892 changes locator recovery and #6874 adds a snapshot-method allowlist entry in the same production file; neither changes these decode hunks. This is independent of the earlier CLI dispatch, request-scope, quota-source and recovery-fixture PRs.Not run: PostgreSQL integration, live Agent-host adoption, the full repository suite or sustained-load qualification. No provider implementation changed. The proposal remains subject to normal review and the performance owner-review gate; no merge or deployment is included.