Repository navigation
Conversation
Signed-off-by: aihop <4408344+hhyykk@users.noreply.github.com>
hhyykk
requested review from
huangruiteng,
loopx-agent and
songoow
as code owners
October 21, 2026 12:40
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal And Delivered Outcome
Three canonical Todo recovery cases failed with
state_file_missing: their setup deleted the entire registry-declared Goal file while trying to remove legacy Todo display. The shipped Goal health guard correctly refused the input, so these cases never qualified the intended resume behavior.A shared fixture now preserves the same Goal definition and removes only Todo display after canonical capture. The original monitor-repair, generation-wait and capacity-recovery assertions remain. The matrix includes legacy Markdown, File and SQLite. A separate File/SQLite check proves that missing Goal source still denies work, canonical Todos remain readable, and restoring Goal prose restores healthy readback without recreating Todo display.
mainat973914e8cb713ee176737c95750aedb3072b9ea8.Author Declaration
Implemented against
quota should-runsubprocesses reach resume/capacity checks after Todo display removal.Scope And Continuation
Complete within this fixture correction.
_quota_goalowns source construction, canonical capture and Todo-display removal for three scenario families. Its callers keep their independent behavioral assertions. This makes source ownership local to one fixture interface with real File/SQLite adapters.The migration economics are production LOC 0, bridge LOC 0, new RPCs 0. Duplicated fixture setup is retired; this does not claim product-code deletion or another domain migration.
48 open PR file inventories were checked. No other PR modifies
test_resume_planning_projection.py. Shared RFC edits are in the correctness section, separate from the caller/scope payoff checkpoints in #6989/#6990/#6992/#6993/#6995 and the canonical readback work in #6874. No dependent product change is bundled.Validation
6db21f5e3839cc8a8cf715de7c8d86404326d482; test source is identical to the tested working tree.Reproduce:
The missing-Goal scenario remains as explicit refusal/recovery coverage; the original resume assertions are retained. File-only promoted variants become explicit File/SQLite variants; the legacy variants remain. Runtime transport and privacy-audit candidates had no sufficient demonstrated payoff and were left unchanged. No performance, model-backed outcome, production promotion, or full asynchronous lifecycle qualification is claimed. CI and maintainer review remain separate.
Frontend / Visual Evidence
UI impact: none. No product interface or screen changes. Before/after, viewport, preview and craft review: N/A. Input data: synthetic/public fixtures.
Shared-authority RFC Fixture Impact
tests/fixtures/control_plane/coordination_production_scale_v0.json, schemaloopx_coordination_production_scale_fixture_v0: unchanged.Type Of Change / Area
Test fixture refactoring, integration coverage and bilingual RFC clarification. Area: control-plane qualification. The runtime source model and health guard are retained.
Boundary Checklist