Skip to content

test(quota): preserve Goal sources in canonical recovery fixtures - #7001

Open
hhyykk wants to merge 1 commit into
loopx-project:mainfrom
hhyykk:codex/architecture-payoff-round6-20261021
Open

hhyykk wants to merge 1 commit into
loopx-project:mainfrom
hhyykk:codex/architecture-payoff-round6-20261021

Conversation

@hhyykk

@hhyykk hhyykk commented Oct 21, 2026

Copy link
Copy Markdown
Collaborator

Goal And Delivered Outcome

Three canonical Todo recovery cases failed with state_file_missing: their setup deleted the entire registry-declared Goal file while trying to remove legacy Todo display. The shipped Goal health guard correctly refused the input, so these cases never qualified the intended resume behavior.

A shared fixture now preserves the same Goal definition and removes only Todo display after canonical capture. The original monitor-repair, generation-wait and capacity-recovery assertions remain. The matrix includes legacy Markdown, File and SQLite. A separate File/SQLite check proves that missing Goal source still denies work, canonical Todos remain readable, and restoring Goal prose restores healthy readback without recreating Todo display.

  • Basis: the requested architecture study against the TypeScript migration RFC; independently reproduced qualification defect.
  • Intended base: main at 973914e8cb713ee176737c95750aedb3072b9ea8.
  • Scope: one test module and paired RFC clarification. Production code, behavior, permissions and defaults are unchanged.

Author Declaration

  • Written by: model_agent, OpenAI Codex (GPT-6 family).

Implemented against

Criterion Disposition Evidence
Qualify actual caller semantics implemented Real public quota should-run subprocesses reach resume/capacity checks after Todo display removal.
Preserve source/admission failures implemented Canonical data does not waive missing Goal source; both providers retain refusal and restore behavior.
Avoid parallel semantic owners implemented Only fixture construction is shared; production owners and rules are unchanged.
Full Goal-source cutover / runtime payoff out_of_scope This repairs bounded qualification. No runtime improvement or completed migration claim.

Scope And Continuation

Complete within this fixture correction. _quota_goal owns source construction, canonical capture and Todo-display removal for three scenario families. Its callers keep their independent behavioral assertions. This makes source ownership local to one fixture interface with real File/SQLite adapters.

The migration economics are production LOC 0, bridge LOC 0, new RPCs 0. Duplicated fixture setup is retired; this does not claim product-code deletion or another domain migration.

48 open PR file inventories were checked. No other PR modifies test_resume_planning_projection.py. Shared RFC edits are in the correctness section, separate from the caller/scope payoff checkpoints in #6989/#6990/#6992/#6993/#6995 and the canonical readback work in #6874. No dependent product change is bundled.

Validation

  • Tested revision: 6db21f5e3839cc8a8cf715de7c8d86404326d482; test source is identical to the tested working tree.
  • State: finished. Inputs: synthetic/public fixtures only. Linux, Python 3.13, qualified Node 24.
Check kind Result Evidence / limit
regression_parity passed Original main's resume module: 18 passed, 3 failed with missing Goal source. Corrected module plus related health/coordination checks: 53 passed.
real_entrypoint passed Public CLI subprocesses from the checkout's editable installation exercise monitor repair, generation waits, capability changes and missing-source/restore. Goal prose bytes remain unchanged by reads.
real_backend passed Actual File/SQLite stores use the existing canonical fixture factory; no provider mocks.
regression_parity passed Removing canonical initialization in a private copy of the final test module makes all 6 canonical recovery cases fail while all 3 legacy cases pass. This rules out qualification from the retained Goal prose alone.
static passed Ruff, diff checks and paired RFC gate; test-guard and docs-guard review completed.
manual not_run Wheel/sdist were not rebuilt; production and packaging sources are unchanged. This is source-checkout qualification, not installed release qualification.

Reproduce:

uv sync --extra test
uv run --extra test pytest -q tests/control_plane/test_resume_planning_projection.py tests/control_plane/test_contract_health.py tests/control_plane/test_canonical_goal_channel_coordination.py
uv run --extra test ruff check tests/control_plane/test_resume_planning_projection.py
python3 scripts/check_rfc_bilingual.py --base origin/main --head HEAD

The missing-Goal scenario remains as explicit refusal/recovery coverage; the original resume assertions are retained. File-only promoted variants become explicit File/SQLite variants; the legacy variants remain. Runtime transport and privacy-audit candidates had no sufficient demonstrated payoff and were left unchanged. No performance, model-backed outcome, production promotion, or full asynchronous lifecycle qualification is claimed. CI and maintainer review remain separate.

Frontend / Visual Evidence

UI impact: none. No product interface or screen changes. Before/after, viewport, preview and craft review: N/A. Input data: synthetic/public fixtures.

Shared-authority RFC Fixture Impact

  • Shared fixture tests/fixtures/control_plane/coordination_production_scale_v0.json, schema loopx_coordination_production_scale_fixture_v0: unchanged.
  • Added qualification dimensions: SQLite parity for these imported Todo recovery cases and explicit Goal-source absence/restoration. No provider-neutral field, canonical operation, capacity or retention rule changes.
  • Actual local provider arms: File and SQLite. The fixture factory seeds canonical state; this does not exercise production promotion itself.
  • PostgreSQL and read-only legacy/File/PostgreSQL rehearsal: not run; no provider, routing, promotion or compatibility-projection implementation changes.

Type Of Change / Area

Test fixture refactoring, integration coverage and bilingual RFC clarification. Area: control-plane qualification. The runtime source model and health guard are retained.

Boundary Checklist

  • Public-safe fixtures and aggregate evidence; no private source data, raw logs, credentials, internal links or local machine paths.
  • Open PR scope checked; no maintainer-owned benchmark work duplicated.
  • All original scenario assertions retained; source ownership is explicit.
  • Both RFC languages changed and the bilingual diff gate passes.
  • UI impact marked none.
  • Every commit carries a DCO sign-off.

Signed-off-by: aihop <4408344+hhyykk@users.noreply.github.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant