Repository navigation
fix(goals): preserve acceptance guidance with objective adoption - #6999
Open
huangruiteng wants to merge 1 commit into
Open
huangruiteng wants to merge 1 commit into
huangruiteng wants to merge 1 commit into
Conversation
Signed-off-by: huangruiteng <huangrt01@163.com>
huangruiteng
force-pushed
the
codex/pr6987-objective-read-guidance
branch
from
October 21, 2026 11:24
1b8fd7c to
f5af380
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the post-merge P2 from #6987: when a Goal has
goal_objectiveplus cumulative outcomes or configured checks, the sharedgoal-acceptance inspectcommand must carry adoption guidance and the existing acceptance obligations. The prior command-level deduplication kept only the first reason.This change keeps one read command, merges all applicable reason clauses, preserves an existing custom reason, and remains idempotent. It does not add another inspect call or a second acceptance authority.
Verification
work_context.sourcesretained both guidance sets with no extra required inspect.npm run -s typecheck:control-plane, Ruff, Python compile andgit diff --checkpassed.loopx canary premerge --from-git-diff: passed, 18/18 selected checks, 0 failures, 0 manual holds.loopx-metastatus and acceptance inspection succeeded. The active meta Goal currently has no objective/outcomes/checks, so the exact branch was exercised in isolated real File/SQLite Goals instead; no active Goal state was modified.Residual risk
No live-model adoption or benchmark-effect experiment was run. PostgreSQL tests remained conditionally skipped in the TS suite; this diff does not change provider storage behavior and the real provider regression covers File and SQLite.
Related: #6987 post-merge audit discussion
discussion_r4335733624.