Repository navigation
Conversation
Signed-off-by: aihop <4408344+hhyykk@users.noreply.github.com>
hhyykk
requested review from
huangruiteng,
loopx-agent and
songoow
as code owners
October 21, 2026 07:52
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal And Delivered Outcome
Normal
manager-inboxcommands load the full compatibility CLI, although the selected-command dispatcher already provides the same parser and native runtime request scope. This adopts that existing path and deletes the duplicate compatibility dispatch branch. Inbox command inputs, outputs, guards and durable effects stay the same; unrelated CLI imports disappear.68e99ad93ef1954a0bf90ad7158ffb85cf365f2d.unexpected module import: loopx.cliand passes with identical response/receipt bytes on the new entrypoint.main; complete within this CLI scope.Author Declaration
Implemented against
Specification:
docs/architecture/rfcs/typescript-control-plane-migration-v0.md, revision68e99ad93ef1954a0bf90ad7158ffb85cf365f2d.loopx/cli_runtime.py, normal installed CLIloopx/cli.py; compatibility CLI uses the shared dispatcherSelf-check: production, test and docs guard review; related tests, real disposable File/SQLite records, installed artifacts and fresh main integration. No real model or external delivery qualification claimed.
Scope And Continuation
cli_runtime.pyor changes Inbox dispatch hunks. refactor(todos): compose full readback in one TypeScript transaction #6874/perf(control-plane): reuse acceptance reads within one Todo snapshot #6984 concern Todo reads; refactor(collaboration): converge return delivery and restart recovery in TypeScript #6855 concerns return delivery/recovery. Shared RFC/README edits and unrelatedcli.pyhunks are acknowledged; there is no duplicate implementation.Validation
d941ee98c599e6edf5a006d14e6cbe8e07010b86on68e99ad93ef1954a0bf90ad7158ffb85cf365f2d.delivered:falseComplete-command performance
Linux; Python 3.11; Node 24.21.0 / SQLite 3.53.4; disposable synthetic Goal. Each sample starts a fresh Python CLI process, uses a warm managed native runtime and records a new result update. Includes parsing, imports, registry lookup, source reads, RPC and durable result recording. The harness asserts loaded Python and TS roots; each child emits a source-origin proof. No timestamp normalization beyond a fixed semantic-fixture clock and disposable-root substitution.
Fresh final comparison: main
68e99ad93ef1954a0bf90ad7158ffb85cf365f2dversus this HEAD, 15 samples per arm per history; all seven SQLite semantic/persisted-state observations match.Supporting pinned-base repeated/reversed SQLite series (30 samples/arm/history) measured p95 1,096.8 → 386.7 ms and 1,135.5 → 363.6 ms. File/controlled profiles (15/arm) also improved. That earlier baseline was
98709770d80e9c332f3c07d2b545226a6dd17521; the five measured runtime files have unchanged hashes after rebase. Earlier cwd-contaminated and CPU-contended study runs were excluded, not pooled into these figures.These results qualify this CLI overhead change only. They do not measure task success, model quality, token savings, cold native-runtime startup or the entire LoopX application. Full repository tests, Windows, PostgreSQL, browser flows and real model/provider delivery were not run for this scoped change; hosted CI is separate.
Portable qualification harness and reproduction
Save the script below as
qualify.pyoutside both checkouts. Install repository Python dependencies and runnpm ciin both checkouts. Use a qualified Node runtime (the run above used 24.21.0 / SQLite 3.53.4), the same Python interpreter, and idle the machine. Outputs must be separate empty directories. Run sequentially:Compare
receipt.jsonrows for exact equality;performancecontains every sample and method count, andsubprocess_import_receiptsproves actual module origins. Synthetic fixtures only; the script disables usage pings and stops its managed native runtime.Harness SHA256:
703773c33713122c8bbcbfccd7e2201e49573f18f102998d464f55beb8833742.Frontend / Visual Evidence
UI impact: none. No dashboard, browser behavior or presentation surface changes; the paired RFC text documents caller ownership only.
Change Area
Technical Direction
Existing TypeScript control-plane migration, Stage 3 caller adoption. Semantic ownership is unchanged.
Shared-authority RFC fixture impact
Boundary Checklist
python3 scripts/check_rfc_bilingual.py --base origin/main --head HEADpasses.