fix(repository): dedupe/filter source ids before querying in hasManyThrough, hasMany, and hasOne inclusion resolvers

[karthikchundi-commits]

This PR was originally scoped to hasManyThrough only. It now also absorbs the hasMany/hasOne fix from #11764, which was closed in favor of this PR but never actually landed here — consolidating both so the fix isn't lost.

The bug

hasManyThrough, hasMany, and hasOne's inclusion resolvers each passed their raw, unfiltered sourceIds array by reference straight into findByForeignKeys(), which wraps it in an {inq: [...]} where clause and hands that same array to the connector without cloning it first. A connector/query layer that sanitizes an inq array in place (e.g. stripping falsy values before running the query, as the in-memory connector does) then mutates that exact array out from under the caller — shrinking the very sourceIds array each resolver still needs, unmodified, to correctly zip results back onto each original entity. That silently misaligns or truncates the returned array whenever any source entity's key was undefined (e.g. excluded by a fields filter) or duplicated another entity's.

belongsTo and referencesMany inclusion resolvers already pass a fresh, deduplicated, filtered array (never the original reference) before querying. hasManyThrough had no dedup/filter attempt at all; hasMany/hasOne didn't either.

Testing

Added a regression test to each of has-many-through-inclusion-resolver.acceptance.ts, has-many-inclusion-resolver.relation.acceptance.ts, and has-one.inclusion-resolver.acceptance.ts: a duplicate source entity plus one with an undefined key, confirming the result stays length-3 and aligned with the input. Verified each test actually catches the bug by temporarily reverting the corresponding source fix and re-running — reproduces the exact truncation (length 2 instead of 3) this fix addresses.

cd packages/repository && npm run build
cd packages/repository-tests && npm run build
npx mocha "dist/__tests__/**/*.js"

128 passing, 8 pending (pre-existing, unrelated to this change), no failures.

Checklist

• DCO (Developer Certificate of Origin) signed in all commits
• npm test passes on your machine
• New tests added or existing tests modified to cover all changes
• Code conforms with the style guide — eslint and prettier both clean on all changed files

[aaqilniz]

Hi, @karthikchundi-commits. Thanks for the PR. Everything seems good. Just one small piece of feedback I'd like to give is that the comments in the code are too descriptive. Can we make them concise and leave the detailed explanation here in the PR description?

[karthikchundi-commits]

@dhmlau Two things:

1. Trimmed the inline comments to a couple of lines each, per your feedback — the detailed rationale now lives only in the PR description and commit messages.
2. Folded in the hasMany/hasOne fix from fix(repository): dedupe/filter source ids before querying in hasMany and hasOne inclusion resolvers #11764. That PR's CI was actually green by the time it was closed (the one real failure was fixed by a follow-up commit), but it never got merged here as expected — its diff only ever touched hasManyThrough. Consolidated both into this PR now so the hasMany/hasOne fix isn't lost. Title and description updated to reflect the full scope; all three resolvers now have matching regression tests, 128 passing / 8 pending (pre-existing) locally.