[bjorkert]

Adds remote profile switching to the profiles customization, so LoopFollow can switch Loop to a saved profile, and makes saved profiles editable without loading them.

Loop uploads every saved profile to the Nightscout profile store next to Default, re-uploads when a profile is saved, renamed or deleted, and lists profile-switch in loop.testingDetails.remoteCommands. The switch is an OTP-protected remote command that carries a fingerprint of the profile values the caregiver previewed. Loop checks it against the saved profile it is about to activate, then runs the same validation and load as the Profiles screen, so the basal schedule is written to the pump before the settings change. The result goes back through the return push, naming the profile, and a local notification; failures also post a Nightscout note. A pump error or a profile edited after upload leaves the settings unchanged and tells the caregiver why.

The profile switch does not go through the shared remote command code. RemoteDataServicesManager hands profile-switch pushes to a handler in NightscoutService that runs the same steps in the same order (duplicates, expiration, OTP with the shared secret and used-OTP list, action, reply push, note on error), and profile-switch is added to remoteCommands when the device status is uploaded, next to what other customizations list there. Together with keeping the LoopKit project entries and the Profiles sheet on dev apart from basal_lock's, this makes profiles independent of every other customization: profiles, remote_carb_edit, remote_window and basal_lock apply in any order without variant patches and give the same tree, and each can be removed on its own. With remote_window, profile switches keep the caregiver app's expiration and are not listed in the dev command history.

This changes dev_profiles (dev and main 3.14.11) and nextdev_profiles. The previous versions are archived as *_noremote, so workspaces that have them show an update, and dev_profiles_basal_lock is no longer needed. main380 and main382 are unchanged.

Saved profiles can now be edited from the profile detail screen without loading them. The detail screen uses the same tap-to-edit cards as Therapy Settings and opens the same editors, with their guardrail warnings, confirmations and authentication. The editors save to the profile file only; nothing reaches Loop's current settings or the pump until the profile is loaded, and editing the active profile offers to load it. The help texts and the Profile Outdated prompt were updated to match (its buttons are now Save Current Settings and Keep Saved Profile).

Loading a profile saves all four schedules in one settings change with the name set first, so Nightscout only gets complete profile documents, and the pump completion keeps the view model alive so a basal schedule written to the pump is always followed by the settings save.

LoopFollow side: loopandlearn/LoopFollow#790

To test:

export PATCH_BRANCH=remote_profile
/bin/bash -c "$(curl -fsSL https://raw.githubusercontent.com/loopandlearn/lnl-scripts/main/CustomizationSelect.sh)"
unset PATCH_BRANCH

[marionbarker]

Test

This was tested in conjunction with LoopFollow PR 790: Switch Loop profiles from the Loop remote screen

It is successful both on the Loop phone alone and in conjunction with the LoopFollow remote command as added by that LoopFollow PR.

It does not work with the latest version of LoopWorkspace next-dev, commit 97b2cfc.
Keeping up with next-dev is a separate issue and not part of this PR.

[marionbarker]

Test

✅ successful test on LoopWorkspace main, release v3.14.11.

Overview

Because many patches were touched, need to make sure they all work with LoopWorkspace main (not just that they apply without errors.)

• basal_lock (14)
• profiles (13)
• remote_edit_carbs (17)
• remote_window (16)

Test all 4

Use the Add in Order test below and build to make sure all 4 items work; then continue the test as each is removed

• remote_window = test build only
• each of the others, ensure they work on the Loop phone and, where appropriate, as a remote command from the LoopFollow phone:
  • ✅ basal_lock (works if customized, not available if not)
  • ✅ profiles (works if customized, not available if not)
  • ✅ LoopFollow: remote profile switch (works if customized, not available if not)
  • ✅ LoopFollow: remote carb edit (works if customized, not available if not)

Test order

Add in order: 13, 14, 16, 17 - make sure all apply and build is successful (✅)
Remove: 13, 16, 17, 14 - make sure each removal is successful and builds and has expected customization

• (lnl-scripts entry: 40, ##, 60, build, test what is included; then move to next ##)

After the removal, ensure clone is clean

• the only thing not cleaned is some localization strings in LoopKit and NightscoutService
• both of these are changes from version 1.0 to 1.1 that happened from building with Xcode
• nothing to worry about

[marionbarker]

Approved by test for LoopWorkspace main, v3.14.11

[marionbarker]

Test

Now that the variants that depend on other customizations are removed, this should be much more stable.
✅ test for main was successful

Test for next-dev will be in the next comment.

Test Details

main branch, v3.14.11

examine main branch for conflicts:

export PATCH_BRANCH=remote_profile
/bin/bash -c "$(curl -fsSL https://raw.githubusercontent.com/loopandlearn/lnl-scripts/main/CustomizationSelect.sh)"

✅ no conflicts found

ensure all 4 of the old variants apply and build

export PATCH_BRANCH=remote_profile
/bin/bash -c "$(curl -fsSL https://raw.githubusercontent.com/loopandlearn/lnl-scripts/main/CustomizationSelect.sh)" basal_lock profiles remote_carb_edit remote_window

✅ all four apply successfully
✅ successful build, customizations are on the phone

Check that remote profile adjustment works for this build in conjunction with loopandlearn/LoopFollow#790 (comment)

✅ on Loop phone, profile behavior is nominal

• ✅ create new profile after modifying therapy settings
• ✅ rename profile without loading
• ✅ load saved profile

Test that remote profiles work from LoopFollow
✅ On LoopFollow phone, load saved profile - check on Loop phone, therapy is updated to new profile and profile shows the correct name
✅ When profile is modified on Loop phone, the LoopFollow phone updates promptly with the correct profile showing the Active flag
✅ When profile is deleted on Loop phone, the profile is no longer in the list for LoopFollow phone

[marionbarker]

Test

This is a test for next-dev, commit 97b2cfc. Only the profiles customization is updated to work with next dev.

Test Details

next-dev, commit

examine next-dev branch for conflicts:

export PATCH_BRANCH=remote_profile
/bin/bash -c "$(curl -fsSL https://raw.githubusercontent.com/loopandlearn/lnl-scripts/main/CustomizationSelect.sh)"

✅ profiles does not conflict.

• as expected, basal_lock and negative_insulin still conflict and will be updated in PR basal_lock, negative_insulin: update nextdev patches for current next-dev #109

✅ successfully apply the customization
✅ successful build, customizations are on the phone

Check that remote profile adjustment works for this next-dev build in conjunction with loopandlearn/LoopFollow#790 (comment)

✅ on Loop phone, profile behavior is nominal

• ✅ create new profile after modifying therapy settings
• ✅ rename profile without loading
• ✅ load saved profile

Test that remote profiles work from LoopFollow
✅ On LoopFollow phone, load saved profile - check on Loop phone, therapy is updated to new profile and profile shows the correct name
✅ When profile is modified on Loop phone, the LoopFollow phone updates promptly with the correct profile showing the Active flag
✅ When profile is deleted on Loop phone, the profile is no longer in the list for LoopFollow phone

I'm going to approve this as is. But I note 2 issues for a later PR, if we decide to make a change.

• On the Loop phone, I can delete a profile that is currently the active / loaded one
  • No change to the Therapy Settings
  • Both Loop and LoopFollow indicate no active profile
• Unlike adding carbs and bolusing, there is no indication on the Loop phone that a remote profile swap has taken place

[marionbarker]

Approve by test.
Thanks for decoupling some customizations.