Repository navigation
Loop predictive low alarm uses the full forecast - #809
Merged
Merged
Conversation
…e Download Prediction setting
marionbarker
approved these changes
Nov 2, 2026
marionbarker
left a comment
marionbarker
left a comment
Collaborator
There was a problem hiding this comment.
Approve by code review and test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The predictive low alarm for Loop reads Loop's full uploaded forecast, up to 60 minutes ahead, independent of Hours of Prediction under Graph Settings, the same way it already works for Trio. The Download Prediction setting is removed, so the Loop forecast line, min/max and the alarm are always available.
Fixes #731. LF Hub gets the matching change in loopandlearn/lfhub, and #796 needs storage.downloadPrediction dropped from HubClient's client settings once this is in dev.