Skip to content

feat(agent): add FurtherQuestions to ConversationResponse - #112

Merged
hogan-yuan merged 1 commit into
mainfrom
feat/agent-further-questions
Aug 11, 2026
Merged

feat(agent): add FurtherQuestions to ConversationResponse#112
hogan-yuan merged 1 commit into
mainfrom
feat/agent-further-questions

Conversation

@hogan-yuan

Copy link
Copy Markdown
Member

What

The agent workflow_finished event's outputs carry a further_questions list — the "you might also ask" follow-up suggestions — that the Go SDK dropped. ConversationResponse and the internal workflowOutputs only modeled answer/references, so the field was lost on both the blocking response and the streamed WorkflowFinishedEvent.

Change

  • Add FurtherQuestions []string (json:"further_questions") to ConversationResponse and its UnmarshalJSON raw struct.
  • Add it to the internal workflowOutputs and thread it through the workflow_finished fold in stream.go.

Tests

Extended the blocking TestUnmarshalSucceededConversationResponse and the streamed workflow_finished assertion to cover FurtherQuestions. go test ./agent/, go vet, and gofmt all clean.

Companion to longbridge/openapi#564 (same field across the other language SDKs).

The workflow_finished event's outputs carry a further_questions list
(suggested follow-ups, "you might also ask") that the SDK dropped.
Add FurtherQuestions to ConversationResponse and workflowOutputs, thread
it through the workflow_finished fold, and cover it in the blocking and
streamed tests.
@hogan-yuan
hogan-yuan enabled auto-merge (squash) August 11, 2026 09:16
@hogan-yuan
hogan-yuan disabled auto-merge August 11, 2026 10:15
@hogan-yuan
hogan-yuan enabled auto-merge (squash) August 11, 2026 10:15
@hogan-yuan
hogan-yuan disabled auto-merge August 11, 2026 10:15
@hogan-yuan
hogan-yuan merged commit daa9631 into main Aug 11, 2026
@hogan-yuan
hogan-yuan deleted the feat/agent-further-questions branch August 11, 2026 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant