Repository navigation
Align editor toolbar buttons and sidebar graph switch - #99
Open
tiensonqin wants to merge 1 commit into
Open
tiensonqin wants to merge 1 commit into
tiensonqin wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sidebar graph switch could collapse to a 44-point control, causing graph names such as
My notesto render beyond the left edge. Give the menu a bounded width and let its label fill that space while preserving room for Settings.Keep the Code/Calculator new-block toolbar action, with the same button size and style as adjacent controls on iOS and Android. On iOS its icon now uses the smaller default size.
Validation:
dune build @shared/native/runtest: 1192 tests passed, including toolbar style and action checks for both native backends.The iPad simulator stalled during boot, so the updated layout has not been revalidated on iPad in this change.