Skip to content

Protect today’s journal and fix localized dialogs and Code/Calculator return keys - #97

Merged
tiensonqin merged 1 commit into
mainfrom
fix/protect-todays-journal
Oct 25, 2026
Merged

tiensonqin merged 1 commit into
mainfrom
fix/protect-todays-journal

Conversation

@tiensonqin

@tiensonqin tiensonqin commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor

Protect today’s journal from deletion in the shared OCaml permissions and mutation layer, remove duplicate localized Cancel actions, and use Enter for newlines / Shift+Enter for new blocks in Code and Calculator on iOS and Android.

Behavior Before After
Delete today’s journal Deletion was allowed Delete is hidden and direct/stale deletion is rejected; past and future journals remain deletable
Localized destructive dialogs A translated Cancel could appear beside an extra system Cancel Exactly one semantic Cancel action for graph deletion, page deletion and sign-out
Code / Calculator keyboard Enter created a block; Shift+Enter inserted a newline Enter inserts a newline; Shift+Enter creates one new block and preserves selection/handoff typing

Math and ordinary text keep their existing key behavior. Pending journal deletions are checked against the operation’s recorded local day so replay remains deterministic across midnight.

The iOS dialog fix pins logseq/lui#272. No recordings, logs, release artifacts or signing files are included.

Validation:

  • Full OCaml gate: 1186 tests passed. An existing 100ms timing assertion initially failed during parallel compilation, then passed in isolation and in the full rerun without changing its threshold.
  • iOS 26 Release checks: English, Chinese, Japanese and French native alerts each show one Cancel and one Delete; Enter/Shift+Enter handoff and UTF-16 selection; Code/Math previews and focus transfer.
  • Android: 13 keyboard tests passed; real-core Calculator scenario passed with live 42/126 results, Enter staying in the block, Shift+Enter adding exactly one block, and long-press selection.
  • Release simulator and device archive verified app shortcuts, Share Extension and native runtime exports.

TestFlight 2.0.2 (38), source d6879d68, was uploaded successfully using Xcode Organizer on October 25, 2026. Distribution logs confirm testFlightInternalTestingOnly=false. Apple processing completion, assignment to the external Native Testers group, and saving the three-item changelog in App Store Connect have not been verified.

@tiensonqin
tiensonqin merged commit ad80ce0 into main Oct 25, 2026
3 checks passed
@tiensonqin
tiensonqin deleted the fix/protect-todays-journal branch October 25, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant