Repository navigation
deps: Dependabot's cargo and Actions bumps, applied (MSRV 1.89, Burn 0.22), minus a toolchain pin - #34
Merged
Conversation
…0.22), minus a toolchain pin Dependabot's two open PRs (#31 cargo, #21 Actions) were red, for reasons of their own: - #31, cargo: moxcms 0.9 needs rustc 1.89, the MSRV job's 1.88 failed; THIRD_PARTY.md was not regenerated; its quality-ratchet failure was the base's (fixed in #33). Now: moxcms 0.9, the workspace rust-version and the MSRV job at 1.89 (CONTRIBUTING and AI_USAGE state it), THIRD_PARTY.md regenerated, tokio 1.53.2 and pyo3 0.29.3 in both lockfiles that carry them (studio's own lock follows moxcms). Output is byte-identical to the 0.3.0 release binary on 237 sampled traces. - burn 0.22 (and burn-onnx and burn-store, which the PR left at 0.21): not a drop-in. The backend is no longer a type parameter but part of the `Device` the weights load onto, the generated `Model` is no longer generic, `burnpack` is no longer a burn-store feature and `into_vec` is `try_into_vec`. `Restorer` is now one type holding a device; the backend features pick it (`cuda(0)`, `wgpu`, `flex`). The Burn path did not build on main before this either: build.rs formatted a `PathBuf` with `{}` and passed it to `input(&str)`. Checked on the flex (CPU) backend: `--restore on` through the Burn weights gives the same SVG as through ONNX Runtime on three web-tier JPEGs. CUDA and wgpu are untested here. - #21, Actions: the bump included `dtolnay/rust-toolchain@1.98.0` -> `@1.120.0`; that tag is the Rust toolchain the job installs, not an action version, and 1.120.0 does not exist, so every job failed at "Set up toolchain". That one stays; the rest of the bump (checkout 7, upload-artifact 7, download-artifact 8, setup-python 7, setup-node 7, setup-go 7, setup-java 6, setup-dotnet 6, docker/* 4-7, gh-release 3, pages 5) is applied, and dependabot.yml now ignores the toolchain action so it is not proposed again. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016AZWMqqHhRQ337N5EWhNC6
…ext are Burn 0.22's CubeCL runtime depends on `buildid` (MPL-2.0, file-level weak copyleft), so `cargo deny` failed on the Dependabot bumps' PR with "licenses FAILED". It is reached the same way as the two MPL crates already allowed by name: through the optional Burn restorer (feature `model`), never in the default build, and already listed in docs/THIRD_PARTY.md. Named per crate so that a further MPL dependency is still a decision; if the project would rather not take one, the alternative is to hold burn at 0.21. `cargo deny --all-features check`: advisories, bans, licences and sources ok. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016AZWMqqHhRQ337N5EWhNC6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This supersedes Dependabot's two open PRs, #31 (cargo) and #21 (GitHub Actions). Both were red. I can't push to Dependabot's branches, so this applies their updates here with the fixes they needed. Merging it should let Dependabot close both.
Cargo (#31)
moxcms0.9 needs rustc 1.89, which failed the MSRV job. The workspacerust-versionand the MSRV job are now 1.89, andCONTRIBUTING.mdanddocs/AI_USAGE.mdsay so.docs/THIRD_PARTY.mdis regenerated. Thelicencesjob had failed because it was stale.tokio1.53.2 andpyo30.29.3 are bumped.studio/src-tauri/Cargo.lockfollowsmoxcms.burn,burn-onnxandburn-storego to 0.22. The PR had leftburn-storeat 0.21, and 0.22 is not a drop-in:Devicethe weights load onto;Modelis no longer generic;burnpackis no longer aburn-storefeature;into_vecbecametry_into_vec.Restoreris now one type holding a device, and the backend features pick it:cuda(0),wgpu,flex.The Burn path didn't build on main before this either:
build.rsformatted aPathBufwith{}and passed it toinput(&str).The PR's quality-ratchet failure was main's own, fixed in quality ratchet green again after 0.3.0: layers lints, tests for the untested new code #33.
Actions (#21)
dtolnay/rust-toolchain@1.98.0to@1.120.0. That tag is the Rust toolchain the job installs, not an action version, and 1.120.0 doesn't exist, so every job failed at "Set up toolchain". It stays at 1.98.0, anddependabot.ymlnow ignores that action.How verified
cargo test --release --workspacepasses (61 test binaries).cargo fmt --all -- --checkis clean.cargo +1.89 check --workspacepasses.tools/third_party.py --checkpasses, and theworkflows/*.ymlanddependabot.ymlparse.--restore on, on three web-tier JPEGs.download-artifact8 andupload-artifact7 are the most likely to need a follow-up, because they're used by the release workflow.🤖 Generated with Claude Code
https://claude.ai/code/session_016AZWMqqHhRQ337N5EWhNC6
Generated by Claude Code