fix: Use target architecture for image inspection in non-Docker drivers #1955
+27
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using non-Docker drivers (like Kubernetes), the inspectImage function was falling back to GetImageConfig which defaults to linux/amd64 architecture. This caused architecture mismatches when the target platform was different. Changes: - Added GetImageConfigForArch function to image package - Modified inspectImage to retrieve target architecture from driver - Updated inspectImage to use architecture-specific image config retrieval - Added proper error handling with descriptive messages Fixes architecture detection for Kubernetes and other non-Docker drivers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using non-Docker drivers (like Kubernetes), the inspectImage function was falling back to GetImageConfig which defaults to linux/amd64 architecture. This caused architecture mismatches when the target platform was different.
Changes:
Fixes architecture detection for Kubernetes and other non-Docker drivers.