Add S3-specific endpoint to generated AWS profile - #473
Draft
anisaoshafi wants to merge 1 commit into
Draft
Conversation
anisaoshafi
added
semver: patch
docs: skip
anisaoshafi
force-pushed
the
support-s3-to-aws-profile
branch
2 times, most recently
from
August 31, 2026 14:11
15292ec to
a55a980
Compare
anisaoshafi
force-pushed
the
support-s3-to-aws-profile
branch
from
August 31, 2026 14:42
a55a980 to
295b8ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
aws --profile localstackused directly (not through lstk's own proxies) sent S3 requests to the profile's general endpoint, breaking S3's virtual-host-style bucket addressing.Solution
lstk setup awsnow writes an S3 endpoint override in a [services localstack] block, referenced via services = localstack in the profile. It reuses the existing endpoint.S3Addressing helper already used by the Terraform/CDK proxies. Idempotency checks and the existing --force overwrite behavior extend to cover it.Review
Small, self-contained, covered by unit and integration tests. Self-merge candidate.
Closes DEVX-755