fix(faq): DOC-316 / update air-gapped environment response#732
Conversation
kostas-localstack
requested review from
HarshCasper,
quetzalliwrites and
remotesynth
as code owners
| .DS_Store | ||
| .kiro | ||
| .vscode | ||
| .idea |
There was a problem hiding this comment.
Hey @kostas-localstack why do we need to update the gitignorefile for this docs task? I thought we were just updating the wording in the FAQ.
There was a problem hiding this comment.
It initially committed the .idea folder which is a directory created by JetBrains IDEs. It stores IDE-specific configuration. It's best not to push these configurations to the repo as they are specific to each IDE. It's best to keep them local.
There was a problem hiding this comment.
Yes, I'm familiar with the purpose of the .idea folder, but it's not relevant to this change... since you didn't mean to add this change, please revert this commit from your PR (remove this gitignore file from PR).
This is a traditional case of Scope Creep: Let's keep this PR strictly for updating the air-gapped environment response in the FAQ doc (DOC-316).
There was a problem hiding this comment.
Fair point, resolved!
There was a problem hiding this comment.
Thanks for the contribution!
Please fix the mistake of the added gitignore file and revert that commit from this PR. @kostas-localstack
Deploying localstack-docs with
|
| Latest commit: |
69df279
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f146f07c.localstack-docs.pages.dev |
| Branch Preview URL: | https://doc-316-part-1.localstack-docs.pages.dev |
quetzalliwrites
left a comment
quetzalliwrites
left a comment
There was a problem hiding this comment.
tyvm @kostas-localstack, you're a star ⭐
2 participants
1st of 2 parts relating to this Linear task.
Updated the response to the "How do I run LocalStack in a fully air-gapped environment?" question based on a discussion in this Slack thread.