feat: Add notification on Kyc system and extend notification for deposit and withdrawal processes.#414
Merged
forge0x merged 6 commits intoJun 24, 2026
Conversation
…ing, completed) Add an outcome parameter to deposit push notifications so each lifecycle stage can use its own title and body.
Notify users when a withdrawal is submitted to Bridge and when USDT is sent, and centralize send-failure handling with push alerts.
send localized kyc status notifications, skip pushes before initiation, use a dedicated incomplete message, and attach latest KYC links for incomplete notifications.
Notify users on KYC status transitions from bridge webhook handler, with guards for unchanged status and pre-initiation states.
Notify users when a withdrawal is submitted to Bridge and when USDT is sent. Centralize send-failure handling with failed push alerts and add unit tests for the new notification outcomes.
bridge only applies developer_fee_percent when flexible_amount is enabled, fixed amount offramps (implemented in flash) must use developer_fee (USD value), so pass the stored flashFee from the pending withdrawal instead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds localized push notifications across the Bridge deposit, withdrawal, and KYC flows. Each notification type uses outcome-specific copy (EN/ES) and structured FCM data payloads so the mobile app can route users to the right screen.
in the commit b0e3635 , the fix for the flash developer fees on withdrawal request is addressed too
Deposit notifications
Withdrawal notifications
KYC notifications (new)
KYC webhook wiring
Commits
feat: support deposit notification outcomes — deposit module + locale strings (EN/ES)
feat: send withdrawal push notifications on submit and USDT send — withdrawal outcome type expansion
feat: add KYC push notification module — notification module, incomplete deep-link support, unit tests
feat: wire KYC webhook status changes to push notifications — webhook handler integration + tests
Mobile notes for @Nodirbek75
Mobile follow-up for incomplete KYC: on tap, open data.kycLink in a WebView; fall back to bridgeInitiateKyc if links are missing.
Test plan
Unit: test/flash/unit/app/bridge/send-kyc-notification.spec.ts
Outcome mapping, pre-initiation guard, incomplete KYC link attachment, fetch-failure fallback
Unit: test/flash/unit/services/bridge/webhook-server/kyc.spec.ts
Approved / pending / incomplete / rejected webhooks
No push before initiation or on duplicate status
Manual: trigger Bridge KYC webhooks locally (yarn bridge-webhook) for incomplete, approved, rejected
Manual: confirm incomplete push data contains kycLink and tosLink
Manual: confirm no push when account has no bridgeKycStatus (pre-initiation)
Manual: confirm deposit notification still sends with default completed outcome
Mobile: handle bridge_kyc_incomplete tap → open KYC link