[FileCheck] Create test to highlight the "more than 9 back-references" issue. #173501
+7
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@llvm/pr-subscribers-testing-tools Author: Thomas Symalla (tsymalla) ChangesWhen back-referencing more than 9 variables in a CHECK line, FileCheck will fail. I intend to fix this issue in a later PR by adjusting FileCheck. Full diff: https://github.com/llvm/llvm-project/pull/173501.diff 1 Files Affected:
diff --git a/llvm/test/FileCheck/capture-limit.txt b/llvm/test/FileCheck/capture-limit.txt
new file mode 100644
index 0000000000000..8965c7fea7445
--- /dev/null
+++ b/llvm/test/FileCheck/capture-limit.txt
@@ -0,0 +1,7 @@
+; RUN: not FileCheck -input-file %s %s
+
+; Trying to back-reference more than 9 variables is intended to fail.
+
+r0 r1 r2 r3 r4 r5 r6 r7 r8 r9 r9
+
+; CHECK: [[REG1:r0]] [[REG2:r1]] [[REG3:r2]] [[REG4:r3]] [[REG5:r4]] [[REG6:r5]] [[REG7:r6]] [[REG8:r7]] [[REG9:r8]] [[REG10:r9]] [[REG10]]
\ No newline at end of file
|
… issue. When back-referencing more than 9 variables in a CHECK line, FileCheck will fail.
tsymalla
force-pushed
the
fix_backref
branch
from
dd8bb4b to
edb2e21
Compare
Contributor
boomanaiden154
left a comment
boomanaiden154
left a comment
There was a problem hiding this comment.
This test looks like it passes based on the CI results?
It should probably be failing/marked xfail?
Contributor
Author
Yeah, XFail might be more suitable here. I'll update the test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When back-referencing more than 9 variables in a CHECK line, FileCheck will fail.
I intend to fix this issue in a later PR by adjusting FileCheck.