[mlir] Consolidate two implementations of meet (NFC) #167208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch consolidates two implementations of meet using "if constexpr", migrating away from the SFINAE-based approach.
Member
|
@llvm/pr-subscribers-mlir Author: Kazu Hirata (kazutakahirata) ChangesThis patch consolidates two implementations of meet using Full diff: https://github.com/llvm/llvm-project/pull/167208.diff 1 Files Affected:
diff --git a/mlir/include/mlir/Analysis/DataFlow/SparseAnalysis.h b/mlir/include/mlir/Analysis/DataFlow/SparseAnalysis.h
index 985573476ab78..89da84346c109 100644
--- a/mlir/include/mlir/Analysis/DataFlow/SparseAnalysis.h
+++ b/mlir/include/mlir/Analysis/DataFlow/SparseAnalysis.h
@@ -138,27 +138,24 @@ class Lattice : public AbstractSparseLattice {
/// Meet (intersect) the information contained in the 'rhs' value with this
/// lattice. Returns if the state of the current lattice changed. If the
- /// lattice elements don't have a `meet` method, this is a no-op (see below.)
- template <typename VT,
- std::enable_if_t<lattice_has_meet<VT>::value> * = nullptr>
+ /// lattice elements don't have a `meet` method, this is a no-op.
+ template <typename VT>
ChangeResult meet(const VT &rhs) {
- ValueT newValue = ValueT::meet(value, rhs);
- assert(ValueT::meet(newValue, value) == newValue &&
- "expected `meet` to be monotonic");
- assert(ValueT::meet(newValue, rhs) == newValue &&
- "expected `meet` to be monotonic");
-
- // Update the current optimistic value if something changed.
- if (newValue == value)
- return ChangeResult::NoChange;
-
- value = newValue;
- return ChangeResult::Change;
- }
+ if constexpr (lattice_has_meet<VT>::value) {
+ ValueT newValue = ValueT::meet(value, rhs);
+ assert(ValueT::meet(newValue, value) == newValue &&
+ "expected `meet` to be monotonic");
+ assert(ValueT::meet(newValue, rhs) == newValue &&
+ "expected `meet` to be monotonic");
+
+ // Update the current optimistic value if something changed.
+ if (newValue == value)
+ return ChangeResult::NoChange;
+
+ value = newValue;
+ return ChangeResult::Change;
+ }
- template <typename VT,
- std::enable_if_t<!lattice_has_meet<VT>::value> * = nullptr>
- ChangeResult meet(const VT &rhs) {
return ChangeResult::NoChange;
}
|
tgymnich
approved these changes
Nov 9, 2025
kuhar
reviewed
Nov 9, 2025
kuhar
approved these changes
Nov 9, 2025
Collaborator
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/52/builds/12692 Here is the relevant piece of the build log for the reference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch consolidates two implementations of meet using
"if constexpr", migrating away from the SFINAE-based approach.