[CIR] Add support for five trivial expression types #1987
Closed
+268
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lanza
requested review from
andykaylor,
bcardosolopes and
xlauko
as code owners
lanza
added a commit
that referenced
this pull request
Nov 16, 2025
This patch implements support for five straightforward C++ expression types that can be directly ported from traditional CodeGen: 1. SizeOfPackExpr - C++11 variadic template pack size operator 2. FixedPointLiteral - Embedded fixed-point arithmetic literals 3. MaterializeTemporaryExpr - Temporary lifetime extension for const refs 4. ConceptSpecializationExpr - C++20 concept satisfaction checks 5. RequiresExpr - C++20 requires expression evaluation All implementations follow the same pattern as CGExprScalar.cpp, generating compile-time constant values where appropriate. Each feature includes comprehensive test coverage. These are simple additions that increase C++ language coverage without introducing new high-level CIR abstractions. ghstack-source-id: 1a523d0 Pull-Request: #1987
lanza
added a commit
that referenced
this pull request
Nov 18, 2025
This patch implements support for five straightforward C++ expression types that can be directly ported from traditional CodeGen: 1. SizeOfPackExpr - C++11 variadic template pack size operator 2. FixedPointLiteral - Embedded fixed-point arithmetic literals 3. MaterializeTemporaryExpr - Temporary lifetime extension for const refs 4. ConceptSpecializationExpr - C++20 concept satisfaction checks 5. RequiresExpr - C++20 requires expression evaluation All implementations follow the same pattern as CGExprScalar.cpp, generating compile-time constant values where appropriate. Each feature includes comprehensive test coverage. These are simple additions that increase C++ language coverage without introducing new high-level CIR abstractions. ghstack-source-id: 1a523d0 Pull-Request: #1987
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This patch implements support for five straightforward C++ expression
types that can be directly ported from traditional CodeGen:
All implementations follow the same pattern as CGExprScalar.cpp,
generating compile-time constant values where appropriate. Each
feature includes comprehensive test coverage.
These are simple additions that increase C++ language coverage
without introducing new high-level CIR abstractions.