Clean up after the unify, fingerprint and MCP fixes - #10
Merged
Merged
Conversation
Stale comments and test titles from withdrawn rulings go, the lstat-failure refusal no longer claims the path exists, the MCP tests assert values and the three-writer case, and the symlink tests run on Windows through a junction.
A symlink loop in a --save-plan target is refused on both platforms, as "cannot be inspected" on Linux. The mcpServers comment named the wrong state: a reordered MCP file with no lock entry reads as collision, not update.
0.2.3: patch, for the post-unify cleanup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
craftar@0.2.3to npm once thereleaserun is approved in thenpmenvironment.lstatcannot inspect a component of a--save-plantarget (a symlink loop or a permission error on Linux), the refusal now reads<path> cannot be inspected (<code>)instead of<path> exists but cannot be resolved (<code>), since the path is not known to exist. The dangling-symlink case keeps the old text. Both refusals still fail closed and write nothing.--save-plansymlink tests now run on Windows too, through a directory junction, which needs no privilege. They usedskipIf(win32)and had never run on Windows; one of them turned Forge unify spine #7's first CI run red on Linux. A new symlink-loop test covers the new message on both platforms.src/, only comments and that one message.Test plan
npm run typecheck: exit 0npm teston Windows: 298 passed / 25 skipped (the symlink tests now run here)node:22-bookworm, non-root): 135 passed / 0 skipped, including the ELOOP branch of the new message