Repository navigation
Allow explicit exclusion of runner session headers - #89
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the changes allowing runner and session headers to be excluded.
No open issues 🎉
What changed in this PR
Allows operators to explicitly exclude injected runner and session headers through ExcludedHeaders, while preserving syntax validation and default header injection.
Changes:
- Removes the validation restriction protecting runner and session headers from exclusion.
- Updates configuration tests to accept exact names and wildcard exclusions.
- Extends proxy tests to verify session-header exclusions and default preservation across app routes.
| File | Description |
|---|---|
| orchestrator/http_test.go | Tests explicit session-header exclusions and default preservation. |
| orchestrator/app.go | Allows runner and session headers to pass exclusion validation. |
| orchestrator/app_test.go | Updates environment, flag, and validation tests for permitted exclusions. |
Review effort: Balanced
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Allow operators to exclude injected runner/session headers through
ExcludedHeaders, includingLivepeer-Session-*. Header-name and wildcard syntax validation still applies; default header injection is unchanged.Removes the obsolete reserved-header rejection cases from the existing validation test.
Validation passed:
go test -race ./orchestrator -count=1,go test -race -short ./cmd/livepeer -count=1, andgo vet ./orchestrator ./cmd/livepeer.