Skip to content

Allow explicit exclusion of runner session headers - #89

Merged
j0sh merged 2 commits into
mainfrom
ja-codex/allow-session-header-exclusions
Nov 13, 2026
Merged

j0sh merged 2 commits into
mainfrom
ja-codex/allow-session-header-exclusions

Conversation

@j0sh

@j0sh j0sh commented Nov 13, 2026 •

Copy link
Copy Markdown
Collaborator

Allow operators to exclude injected runner/session headers through ExcludedHeaders, including Livepeer-Session-*. Header-name and wildcard syntax validation still applies; default header injection is unchanged.

Removes the obsolete reserved-header rejection cases from the existing validation test.

Validation passed: go test -race ./orchestrator -count=1, go test -race -short ./cmd/livepeer -count=1, and go vet ./orchestrator ./cmd/livepeer.

Copilot AI balanced review requested due to automatic review settings November 13, 2026 01:36

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are recorded for the changes allowing runner and session headers to be excluded.

No open issues 🎉

What changed in this PR

Allows operators to explicitly exclude injected runner and session headers through ExcludedHeaders, while preserving syntax validation and default header injection.

Changes:

  • Removes the validation restriction protecting runner and session headers from exclusion.
  • Updates configuration tests to accept exact names and wildcard exclusions.
  • Extends proxy tests to verify session-header exclusions and default preservation across app routes.
File Description
orchestrator/​http_test.go Tests explicit session-header exclusions and default preservation.
orchestrator/​app.go Allows runner and session headers to pass exclusion validation.
orchestrator/​app_test.go Updates environment, flag, and validation tests for permitted exclusions.

Review effort: Balanced

@j0sh
j0sh deployed to docker-publish November 13, 2026 01:39 — with GitHub Actions Active
@j0sh
j0sh deployed to docker-publish November 13, 2026 01:40 — with GitHub Actions Active
@j0sh
j0sh deployed to docker-publish November 13, 2026 01:40 — with GitHub Actions Active
@j0sh
j0sh deployed to docker-publish November 13, 2026 01:40 — with GitHub Actions Active
Copilot AI balanced review requested due to automatic review settings November 13, 2026 01:44

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The test lacks positive validation cases for runner/session headers and their wildcard patterns, leaving the new acceptance behavior without regression coverage.

1 open issue

Review effort: Balanced

Comment thread orchestrator/app_test.go Resolved
@j0sh
j0sh deployed to docker-publish November 13, 2026 01:47 — with GitHub Actions Active
@j0sh
j0sh deployed to docker-publish November 13, 2026 01:47 — with GitHub Actions Active
@j0sh
j0sh deployed to docker-publish November 13, 2026 01:47 — with GitHub Actions Active
@j0sh
j0sh deployed to docker-publish November 13, 2026 01:48 — with GitHub Actions Active
@j0sh
j0sh merged commit 6b8e6bc into main Nov 13, 2026
15 checks passed
@j0sh
j0sh deleted the ja-codex/allow-session-header-exclusions branch November 13, 2026 01:50

This branch was successfully deployed

1 active deployment
docker-publish — 7b650d96 Deployed Nov 13, 2026 by j0sh via docker-pr / promote #186
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants