Skip to content

Allow selective cookie exclusion in application proxies - #88

Merged
j0sh merged 2 commits into
mainfrom
ja-codex/controlcenter-cookie-filter
Nov 13, 2026
Merged

j0sh merged 2 commits into
mainfrom
ja-codex/controlcenter-cookie-filter

Conversation

@j0sh

@j0sh j0sh commented Nov 12, 2026

Copy link
Copy Markdown
Collaborator

Add ExcludedCookies to remove named cookies from application proxy requests while preserving application cookies and other headers. Controlcenter can use this to exclude CF_Authorization when Node handles public proxy traffic directly.

Validation: full orchestrator race tests and the real-binary offchain integration test pass. Proxy coverage includes all URL modes, duplicate Cookie headers, and SSE/WebSocket requests; CLI/configuration checks and help golden are updated.

@j0sh
j0sh deployed to docker-publish November 12, 2026 23:34 — with GitHub Actions Active
@j0sh
j0sh deployed to docker-publish November 12, 2026 23:35 — with GitHub Actions Active
@j0sh
j0sh deployed to docker-publish November 12, 2026 23:35 — with GitHub Actions Active
@j0sh
j0sh deployed to docker-publish November 12, 2026 23:35 — with GitHub Actions Active
@j0sh
j0sh deployed to docker-publish November 13, 2026 00:13 — with GitHub Actions Active
@j0sh
j0sh deployed to docker-publish November 13, 2026 00:13 — with GitHub Actions Active
@j0sh
j0sh deployed to docker-publish November 13, 2026 00:13 — with GitHub Actions Active
@j0sh
j0sh deployed to docker-publish November 13, 2026 00:14 — with GitHub Actions Active
@j0sh
j0sh marked this pull request as ready for review November 13, 2026 00:42
Copilot AI balanced review requested due to automatic review settings November 13, 2026 00:42

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain for the selective cookie-exclusion change.

No open issues 🎉

What changed in this PR

Adds selective cookie exclusion to orchestrator application proxies, allowing ingress cookies such as CF_Authorization to be removed while preserving application cookies and other headers.

Changes:

  • Adds case-sensitive cookie filtering to outgoing application proxy requests.
  • Exposes ExcludedCookies through configuration, CLI flags, and environment variables, with cookie-name validation.
  • Extends proxy and configuration tests and updates documentation and CLI help.
File Description
orchestrator/​http.go Filters named cookies before forwarding proxy requests.
orchestrator/​http_test.go Extends cookie-filtering coverage across URL modes and streaming requests.
orchestrator/​app.go Defines, validates, prints, and applies ExcludedCookies.
orchestrator/​app_test.go Tests environment and flag configuration and cookie-name validation.
docs/​orchestrator.md Documents selective cookie exclusion and case-sensitive matching.
configs/​orchestrator/​config.example.toml Adds a commented selective cookie-exclusion example.
cmd/​livepeer/​testdata/​cli/​orchestrator-help.golden Updates expected help output for --excluded-cookies.

Review effort: Balanced

@j0sh
j0sh merged commit add2ad0 into main Nov 13, 2026
14 checks passed
@j0sh
j0sh deleted the ja-codex/controlcenter-cookie-filter branch November 13, 2026 01:31

This branch was successfully deployed

1 active deployment
docker-publish — ac46136a Deployed Nov 13, 2026 by j0sh via docker-pr / promote #183
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants