Repository navigation
Allow selective cookie exclusion in application proxies - #88
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the selective cookie-exclusion change.
No open issues 🎉
What changed in this PR
Adds selective cookie exclusion to orchestrator application proxies, allowing ingress cookies such as CF_Authorization to be removed while preserving application cookies and other headers.
Changes:
- Adds case-sensitive cookie filtering to outgoing application proxy requests.
- Exposes
ExcludedCookiesthrough configuration, CLI flags, and environment variables, with cookie-name validation. - Extends proxy and configuration tests and updates documentation and CLI help.
| File | Description |
|---|---|
orchestrator/http.go |
Filters named cookies before forwarding proxy requests. |
orchestrator/http_test.go |
Extends cookie-filtering coverage across URL modes and streaming requests. |
orchestrator/app.go |
Defines, validates, prints, and applies ExcludedCookies. |
orchestrator/app_test.go |
Tests environment and flag configuration and cookie-name validation. |
docs/orchestrator.md |
Documents selective cookie exclusion and case-sensitive matching. |
configs/orchestrator/config.example.toml |
Adds a commented selective cookie-exclusion example. |
cmd/livepeer/testdata/cli/orchestrator-help.golden |
Updates expected help output for --excluded-cookies. |
Review effort: Balanced
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
ExcludedCookiesto remove named cookies from application proxy requests while preserving application cookies and other headers. Controlcenter can use this to excludeCF_Authorizationwhen Node handles public proxy traffic directly.Validation: full orchestrator race tests and the real-binary offchain integration test pass. Proxy coverage includes all URL modes, duplicate Cookie headers, and SSE/WebSocket requests; CLI/configuration checks and help golden are updated.