Skip to content

Support authenticated outbound ticket redemption - #85

Merged
j0sh merged 3 commits into
mainfrom
ja-codex/recipient-redemption-headers
Nov 12, 2026
Merged

j0sh merged 3 commits into
mainfrom
ja-codex/recipient-redemption-headers

Conversation

@j0sh

@j0sh j0sh commented Nov 12, 2026

Copy link
Copy Markdown
Collaborator

Managed keyless orchestrators need a recipient-scoped submission credential when sending winning tickets to a standalone redeemer. Add RedeemerHeaders and owner-only RedeemerHeadersFile, following the existing header and secret-file conventions, and pass a cloned header map to the configured HTTP destination. Redirects remain disabled, so submission credentials stay at that destination.

This is the orchestrator → redeemer credential; the redeemer’s existing authorization-webhook headers authenticate its separate redeemer → authorization-service callback. This dependency supports livepeer/naap-ops#119.

Validation: go test -race ./redemption ./redeemer ./orchestrator ./cmd/livepeer passed against current main. Tests cover configured header delivery, cloning, redirect refusal, secret-file permissions, redacted configuration, and CLI help.

@j0sh
j0sh deployed to docker-publish November 12, 2026 08:34 — with GitHub Actions Active
@j0sh
j0sh deployed to docker-publish November 12, 2026 08:34 — with GitHub Actions Active
@j0sh
j0sh deployed to docker-publish November 12, 2026 08:34 — with GitHub Actions Active
@j0sh
j0sh deployed to docker-publish November 12, 2026 08:35 — with GitHub Actions Active
@j0sh
j0sh marked this pull request as ready for review November 12, 2026 08:38
Copilot AI balanced review requested due to automatic review settings November 12, 2026 08:38

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

There are no active review issues blocking approval of the outbound submission credential changes.

No open issues 🎉

What changed in this PR

Adds authenticated outbound ticket submission for keyless orchestrators using a standalone redeemer. Submission credentials remain separate from the redeemer’s authorization-webhook credentials.

Changes:

  • Adds secret RedeemerHeaders configuration and owner-only RedeemerHeadersFile support.
  • Clones configured headers into outbound submissions while preserving redirect refusal.
  • Adds tests for header delivery, cloning, redirect isolation, secret-file permissions, and redaction; updates documentation and CLI help.
File Description
redemption/​http.go Accepts, clones, and applies submission headers.
redemption/​http_test.go Tests header delivery, cloning, nil headers, and redirect refusal.
orchestrator/​app.go Adds credential configuration, validation, and destination wiring.
orchestrator/​app_test.go Tests secret-file loading, permissions, redaction, and direct-flag rejection.
docs/​orchestrator.md Documents submission credentials and destination restrictions.
cmd/​livepeer/​testdata/​cli/​orchestrator-help.golden Adds the headers-file flag and secret environment variable to expected help output.

Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings November 12, 2026 08:40
@j0sh
j0sh deployed to docker-publish November 12, 2026 08:43 — with GitHub Actions Active

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues were identified for the outbound submission-credentials change.

No open issues 🎉

Review effort: Balanced

@j0sh
j0sh deployed to docker-publish November 12, 2026 08:44 — with GitHub Actions Active
@j0sh
j0sh deployed to docker-publish November 12, 2026 08:44 — with GitHub Actions Active
@j0sh
j0sh deployed to docker-publish November 12, 2026 08:44 — with GitHub Actions Active
@j0sh
j0sh merged commit 3533951 into main Nov 12, 2026
14 checks passed
@j0sh
j0sh deleted the ja-codex/recipient-redemption-headers branch November 12, 2026 08:58

This branch was successfully deployed

1 active deployment
docker-publish — 621fb3f7 Deployed Nov 12, 2026 by j0sh via docker-pr / promote #173
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants