Repository navigation
Support authenticated outbound ticket redemption - #85
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
There are no active review issues blocking approval of the outbound submission credential changes.
No open issues 🎉
What changed in this PR
Adds authenticated outbound ticket submission for keyless orchestrators using a standalone redeemer. Submission credentials remain separate from the redeemer’s authorization-webhook credentials.
Changes:
- Adds secret
RedeemerHeadersconfiguration and owner-onlyRedeemerHeadersFilesupport. - Clones configured headers into outbound submissions while preserving redirect refusal.
- Adds tests for header delivery, cloning, redirect isolation, secret-file permissions, and redaction; updates documentation and CLI help.
| File | Description |
|---|---|
redemption/http.go |
Accepts, clones, and applies submission headers. |
redemption/http_test.go |
Tests header delivery, cloning, nil headers, and redirect refusal. |
orchestrator/app.go |
Adds credential configuration, validation, and destination wiring. |
orchestrator/app_test.go |
Tests secret-file loading, permissions, redaction, and direct-flag rejection. |
docs/orchestrator.md |
Documents submission credentials and destination restrictions. |
cmd/livepeer/testdata/cli/orchestrator-help.golden |
Adds the headers-file flag and secret environment variable to expected help output. |
Review effort: Balanced
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Managed keyless orchestrators need a recipient-scoped submission credential when sending winning tickets to a standalone redeemer. Add
RedeemerHeadersand owner-onlyRedeemerHeadersFile, following the existing header and secret-file conventions, and pass a cloned header map to the configured HTTP destination. Redirects remain disabled, so submission credentials stay at that destination.This is the orchestrator → redeemer credential; the redeemer’s existing authorization-webhook headers authenticate its separate redeemer → authorization-service callback. This dependency supports livepeer/naap-ops#119.
Validation:
go test -race ./redemption ./redeemer ./orchestrator ./cmd/livepeerpassed against current main. Tests cover configured header delivery, cloning, redirect refusal, secret-file permissions, redacted configuration, and CLI help.