fix: handle unset fee/reward change timestamps in orchestrator list#586
Merged
fix: handle unset fee/reward change timestamps in orchestrator list#586
Conversation
Use the latest of feeShareUpdateTimestamp and rewardCutUpdateTimestamp (ignoring 0 values) and display "Never" when neither has been set, instead of computing days since Unix epoch (~20521 days). Closes #585 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the orchestrator yield popover so “Latest fee/reward change” no longer shows an absurd “~20521 days ago” when the subgraph returns 0 for unset fee/reward update timestamps. The change treats 0 as “unset”, uses the latest non-zero timestamp across fee/reward updates, and displays “Never” when neither has been set.
Changes:
- Compute a single
latestChangeTimestampas the max offeeShareUpdateTimestampandrewardCutUpdateTimestamp, treating missing values as0. - Render “Never” when the computed latest timestamp is unset (
0), otherwise render “X days ago”. - Update mapped row fields to store
nullfor “never updated” values rather than computing a diff from Unix epoch.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
feeShareUpdateTimestampandrewardCutUpdateTimestamp, treating0as unsetCloses #585
Test plan
🤖 Generated with Claude Code